MSC2674: Event Relationships by uhoreg · Pull Request #2674 · matrix-org/matrix-spec-proposals

uhoreg · 2020-07-07T20:21:17Z

Rendered

Replaces #1849 along with #2675, #2676, and #2677

New FCP: #2674 (comment)

uhoreg

Transfer comments from 1849

proposals/2674-event-relationships.md

kevincox

I think that we should support multiple relations, both of the same type and of differing types.

proposals/2674-event-relationships.md

…r a future MSC

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

This reverts commit e027133.

… the cs api

proposals/2674-event-relationships.md

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

mscbot · 2021-11-23T18:42:56Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

* initial version of event relationship MSC * fix MSC numbers * clarifications * mention multiple relations per event might be useful, but postpone for a future MSC * mention MSC 3051 for proposed multiple relations * remove send_relation endpoint * move e2ee section under sending relations * mention limitation of leaving server-side aggregations out for now * remove mentions of m.reference, we'll sort that out in another MSC * whitespace * argument why m.relates_to should be preserved by redactions more general but still give example of redacted edits * deal with this in the comments * clarify the conditions to meet for a relation * mention specifically that this does not replace replies (yet) * clarify how general rel_types should be * clarify that gaps may cause clients to be unaware of some relations * Update proposals/2674-event-relationships.md Co-authored-by: DeepBlueV7.X <nicolas.werner@hotmail.de> * Update proposals/2674-event-relationships.md Co-authored-by: DeepBlueV7.X <nicolas.werner@hotmail.de> * make wording clearer and move to bottom of section * remove this as references are not defined here anymore * clearer wording * move edge cases to other relevant mscs * clarify that a goal of sticking to this format is backwards compat. * mention MSC 3267, to which m.reference has been extracted * Update proposals/2674-event-relationships.md Co-authored-by: Hubert Chathi <hubert@uhoreg.ca> * Update proposals/2674-event-relationships.md Co-authored-by: Hubert Chathi <hubert@uhoreg.ca> * Update proposals/2674-event-relationships.md Co-authored-by: Matthew Hodgson <matthew@arasphere.net> * Update proposals/2674-event-relationships.md Co-authored-by: Matthew Hodgson <matthew@arasphere.net> * Update proposals/2674-event-relationships.md Co-authored-by: Travis Ralston <travpc@gmail.com> * wrap lines * better wording * this is singular, really * add example of event shape * specify how invalid relations should be treated by the redaction algorithm * fix typo * split up redactions changes in separate MSC * also add new msc to introduction * reword why not adopt m.in_reply_to * remove guidelines how to pick rel_type * mention that the target event must exist in the same room * spell out the conscious (subject, object, verb) triple idea. * Spelling Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * remove paragraph saying what server should accept * Revert "remove paragraph saying what server should accept" This reverts commit e027133. * further specify that a server should reject invalid relations through the cs api * linebreak Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: Bruno Windels <bruno@windels.cloud> Co-authored-by: DeepBlueV7.X <nicolas.werner@hotmail.de> Co-authored-by: Matthew Hodgson <matthew@arasphere.net> Co-authored-by: Travis Ralston <travpc@gmail.com> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

turt2live · 2022-05-27T03:30:38Z

Spec PR: matrix-org/matrix-spec#1062

turt2live · 2022-06-08T21:33:32Z

Merged 🎉

uhoreg added 2 commits July 7, 2020 15:25

initial version of event relationship MSC

9e8460f

fix MSC numbers

3415262

uhoreg commented Jul 7, 2020

View reviewed changes

uhoreg changed the title ~~MSCxxxx: Event Relationships~~ MSC2674: Event Relationships Jul 7, 2020

uhoreg marked this pull request as ready for review July 7, 2020 21:34

uhoreg mentioned this pull request Jul 7, 2020

MSC2675: Serverside aggregations of message relationships #2675

Merged

uhoreg added kind:core MSC which is critical to the protocol's success proposal A matrix spec change proposal proposal-in-review labels Jul 7, 2020

uhoreg mentioned this pull request Jul 7, 2020

MSC1849: Proposal for m.relates_to aggregations #1849

Closed

tulir reviewed Jul 7, 2020

View reviewed changes

proposals/2674-event-relationships.md Outdated Show resolved Hide resolved

Sorunome reviewed Jul 8, 2020

View reviewed changes

proposals/2674-event-relationships.md Outdated Show resolved Hide resolved

turt2live self-requested a review July 20, 2020 21:29

joepie91 reviewed Jul 24, 2020

View reviewed changes

proposals/2674-event-relationships.md Outdated Show resolved Hide resolved

joepie91 reviewed Jul 26, 2020

View reviewed changes

proposals/2674-event-relationships.md Outdated Show resolved Hide resolved

richvdh reviewed Jul 28, 2020

View reviewed changes

jplatte mentioned this pull request Aug 28, 2020

Changes to m.relates_to for in-room verifications and reactions. ruma/ruma#248

Closed

tulir mentioned this pull request Sep 17, 2020

Investigate if there are unspecced endpoints that can be removed matrix-org/synapse#8334

Open

deepbluev7 reviewed Oct 23, 2020

View reviewed changes

proposals/2674-event-relationships.md Show resolved Hide resolved

deepbluev7 mentioned this pull request Oct 29, 2020

MSC2836: Twitter-style Threading #2836

Open

tulir mentioned this pull request Oct 29, 2020

Pan strips out reply/edit metadata matrix-org/pantalaimon#73

Closed

uhoreg mentioned this pull request Jan 8, 2021

MSC2677: Annotations and reactions #2677

Merged

turt2live removed their request for review March 22, 2021 03:00

deepbluev7 reviewed Apr 30, 2021

View reviewed changes

proposals/2674-event-relationships.md Show resolved Hide resolved

kevincox reviewed May 3, 2021

View reviewed changes

proposals/2674-event-relationships.md Outdated Show resolved Hide resolved

clarifications

c00e4f4

turt2live added the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Jun 8, 2021

bwindels added 3 commits June 30, 2021 15:13

mention multiple relations per event might be useful, but postpone fo…

e4c16fa

…r a future MSC

mention MSC 3051 for proposed multiple relations

35fb00c

remove send_relation endpoint

db6213b

turt2live and others added 4 commits November 21, 2021 22:10

Spelling

57cfb55

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

remove paragraph saying what server should accept

e027133

Revert "remove paragraph saying what server should accept"

7cca8ac

This reverts commit e027133.

further specify that a server should reject invalid relations through…

12bdf05

… the cs api

richvdh reviewed Nov 23, 2021

View reviewed changes

proposals/2674-event-relationships.md Outdated Show resolved Hide resolved

linebreak

feb3377

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Nov 23, 2021

turt2live merged commit c8e8b75 into matrix-org:old_master Nov 23, 2021

turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Nov 23, 2021

clokep mentioned this pull request Dec 6, 2021

Do not allow cross-room relations, per MSC2674. matrix-org/synapse#11516

Merged

turt2live added the blocked Something needs to be done before action can be taken on this PR/issue. label Dec 31, 2021

turt2live removed the blocked Something needs to be done before action can be taken on this PR/issue. label May 5, 2022

turt2live self-assigned this May 5, 2022

turt2live mentioned this pull request May 14, 2022

Spec /relations and aggregations matrix-org/matrix-spec#1062

Merged

4 tasks

turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels May 27, 2022

turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jun 8, 2022

zecakeh mentioned this pull request Jun 10, 2022

Incorporate Matrix v1.3 changes ruma/ruma#1145

Closed

66 tasks

This was referenced Jun 14, 2022

MSC2530: Body field as media caption #2530

Merged

MSC2529: Proposal to use existing events as captions for images #2529

Closed

S7evinK mentioned this pull request Sep 29, 2023

Declare support for Matrix 1.3 matrix-org/dendrite#3219

Open

16 tasks

matrixbot mentioned this pull request Nov 1, 2024

Declare support for Matrix 1.3 element-hq/dendrite#3219

Open

16 tasks

Conversation

uhoreg commented Jul 7, 2020 • edited by richvdh Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

uhoreg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kevincox left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mscbot commented Nov 23, 2021

Uh oh!

turt2live commented May 27, 2022

Uh oh!

turt2live commented Jun 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

uhoreg commented Jul 7, 2020 •

edited by richvdh

Loading

kevincox left a comment •

edited

Loading