Skip to content

Fix Docker builds hanging/OOMing#535

Merged
AndrewFerr merged 7 commits intomainfrom
af/docker-timeout
Oct 17, 2022
Merged

Fix Docker builds hanging/OOMing#535
AndrewFerr merged 7 commits intomainfrom
af/docker-timeout

Conversation

@AndrewFerr
Copy link
Member

@AndrewFerr AndrewFerr commented Oct 14, 2022

No description provided.

@AndrewFerr AndrewFerr requested a review from a team as a code owner October 14, 2022 13:24
@AndrewFerr AndrewFerr requested a review from Half-Shot October 14, 2022 13:24
@AndrewFerr AndrewFerr self-assigned this Oct 14, 2022
@AndrewFerr AndrewFerr added S-Tolerable Low/no impact on users Docker Involves docker T-Task Refactoring, enabling or disabling functionality, other engineering tasks. labels Oct 14, 2022
Half-Shot
Half-Shot approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, woo!

@Half-Shot
Copy link
Contributor

Half-Shot commented Oct 17, 2022

This looks like cargo taking too long to download crates, perhaps we need to fix that timeout too.

@AndrewFerr AndrewFerr changed the title Add network timeouts to Docker builds Fix Docker builds hanging/OOMing Oct 17, 2022
@AndrewFerr AndrewFerr merged commit c0efb91 into main Oct 17, 2022
@AndrewFerr AndrewFerr deleted the af/docker-timeout branch October 17, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Half-Shot Half-Shot Half-Shot approved these changes

Assignees

@AndrewFerr AndrewFerr

Labels

Docker Involves docker S-Tolerable Low/no impact on users T-Task Refactoring, enabling or disabling functionality, other engineering tasks.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndrewFerr @Half-Shot