Loading threads with server-side assistance#2735
Merged
Conversation
9 tasks
justjanne
force-pushed
the
justjanne/poc/thread-server-loading
branch
9 times, most recently
from
917adb1 to
37b5fa0
Compare
justjanne
force-pushed
the
justjanne/poc/thread-server-loading
branch
8 times, most recently
from
d247b24 to
a230981
Compare
germain-gg
reviewed
Oct 19, 2022
| toStartOfTimeline: boolean, | ||
| ) => { | ||
| if (timelineSet && thread.rootEvent) { | ||
| if (Thread.hasServerSideSupport) { |
Contributor
There was a problem hiding this comment.
I've recently created feature.ts and it aims to create a support map that is generated when the client is started as I've noticed that a LOT of places were doing a slightly custom check for their own features
| @@ -6658,25 +6841,42 @@ export class MatrixClient extends TypedEventEmitter<EmittedEvents, ClientEventHa | |||
| public async doesServerSupportThread(): Promise<{ | |||
Contributor
There was a problem hiding this comment.
We can probs replace this by feature.ts. Does not need to happen in this PR
| this.doesServerSupportUnstableFeature("org.matrix.msc3440"), | ||
| this.doesServerSupportUnstableFeature("org.matrix.msc3440.stable"), | ||
| this.doesServerSupportUnstableFeature("org.matrix.msc3856"), | ||
| this.doesServerSupportUnstableFeature("org.matrix.msc3856.stable"), |
Contributor
There was a problem hiding this comment.
the .stable have only been defined for msc3440 as far as I've read
Comment on lines
1202
to
+1201
| Thread.setServerSideSupport(threads); | ||
| Thread.setServerSideListSupport(list); | ||
| Thread.setServerSideFwdPaginationSupport(fwdPagination); |
Contributor
There was a problem hiding this comment.
All of that could be replaced by feature.ts
justjanne
force-pushed
the
justjanne/poc/thread-server-loading
branch
from
f988de1 to
e84b7ac
Compare
germain-gg
approved these changes
Oct 28, 2022
Contributor
germain-gg
left a comment
germain-gg
left a comment
There was a problem hiding this comment.
That looks great! 👏
We can punt the changes to feature.ts in a next iteration of work
This was referenced Oct 28, 2022
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Nov 12, 2022
* Loading threads with server-side assistance ([\matrix-org#2735](matrix-org#2735)). Contributed by @justjanne. * Support sign in + E2EE set up using QR code implementing MSC3886, MSC3903 and MSC3906 ([\matrix-org#2747](matrix-org#2747)). Contributed by @hughns. * Replace `instanceof Array` with `Array.isArray` ([\matrix-org#2812](matrix-org#2812)). Fixes matrix-org#2811. * Emit UnreadNotification event on notifications reset ([\matrix-org#2804](matrix-org#2804)). Fixes element-hq/element-web#23590. * Fix incorrect prevEv being sent in ClientEvent.AccountData events ([\matrix-org#2794](matrix-org#2794)). * Fix build error caused by wrong ts-strict improvements ([\matrix-org#2783](matrix-org#2783)). Contributed by @justjanne. * Encryption should not hinder verification ([\matrix-org#2734](matrix-org#2734)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: Enhancement
Related: matrix-org/matrix-react-sdk#9356
Related: #2602
Here's what your changelog entry will look like:
✨ Features