We don't care about the timeline (just fire and forget to load the event)

[MadLittleMods]

We don't care about the timeline (just fire and forget to load the event).

It's probably a misnomer to call it getEventTimeline(): timeline in the first place as it's more accurately used as loadEventInTimeline(): Promise<void> everywhere.

-- #2521 (comment)*

Split out from #2521

Checklist

• Tests written for new code (and old code if feasible)
• Linter and other CI checks pass
• Sign-off given on the changes (see CONTRIBUTING.md)

---

This change is marked as an internal change (Task), so will not be included in the changelog.

[MadLittleMods]

The function signature is Promise<void> here. We shouldn't return anything here.

[robintown]

I'm confused. It doesn't look like this changes any behavior?

[robintown]

this.client.getEventTimeline(...).then(initFields) was already a Promise<void>?

[MadLittleMods]

Sorry, I think I confused my sentiment with this spot (which is totally different, oops) that I mentioned in #2521 (comment) with some blind copy-pasting out of that PR diff. I'm trying to get back to speed with everything going on in that stale PR.

And if we actually wanted to refactor to a fire and forget getEventTimeline pattern here, I'd need to adjust how initFields is done here.

I'll have a think on this one whether it's relevant. Good shout!

[richvdh]

removing review requests while this is in draft