Merged
Conversation
Half-Shot
commented
Sep 9, 2024
dbkr
reviewed
Sep 9, 2024
Member
dbkr
left a comment
dbkr
left a comment
There was a problem hiding this comment.
otherwise this looks good I think
src/client.ts
Outdated
| {}, | ||
| profile, | ||
| { | ||
| prefix: (await this.doesServerSupportUnstableFeature("uk.tcpip.msc4133.stable")) |
Member
There was a problem hiding this comment.
This feels a bit repetitive - maybe a extendedProfilePrefix or something would be useful?
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: This is being worked on with an open source community hat on rather than my Element hat.
For matrix-org/matrix-spec-proposals#4133
While this MSC is in review, I opted to make new methods rather than extend the existing profile methods. I'm open to changing this if that seems more appropriate, but I think it's just as easy to change the methods later once the endpoint stabilizes.
Checklist
public/exportedsymbols have accurate TSDoc documentation.