This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Use findPredecessor in RoomNotifs#getUnreadNotificationCount#10067
Merged
weeman1337 merged 2 commits intodevelopfrom Feb 3, 2023
Merged
Use findPredecessor in RoomNotifs#getUnreadNotificationCount#10067weeman1337 merged 2 commits intodevelopfrom
weeman1337 merged 2 commits intodevelopfrom
Conversation
weeman1337
added
the
T-Task
germain-gg
approved these changes
Feb 3, 2023
Contributor
germain-gg
left a comment
germain-gg
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for tightening the tests in that area 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards matrix-org/matrix-spec-proposals#3946
closes element-hq/element-web#24326
PSF-1887
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.