This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Tidy up IRCLayout.pcss#10189
Merged
SimonBrandner merged 24 commits intomatrix-org:developfrom Apr 23, 2023
luixxiul:IRCLayout
Merged
Tidy up IRCLayout.pcss#10189SimonBrandner merged 24 commits intomatrix-org:developfrom luixxiul:IRCLayout
SimonBrandner merged 24 commits intomatrix-org:developfrom
luixxiul:IRCLayout
Conversation
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
github-actions
bot
added
Z-Community-PR
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
luixxiul
commented
Feb 20, 2023
| text-decoration: none; | ||
| min-width: $MessageTimestamp_width; | ||
| } | ||
| .mx_EventTile[data-layout="irc"] { |
Contributor
Author
There was a problem hiding this comment.
Protection against unintentional override by something in .mx_EventTile:not([data-layout="bubble"]) on _EventTile.pcss
luixxiul
commented
Feb 20, 2023
| --EventTile_irc_line-padding-block: 1px; | ||
|
|
||
| display: flex; | ||
| flex-direction: row; |
Contributor
Author
There was a problem hiding this comment.
Since there is not an inherited value for the property, this declaration can safely be removed.
germain-gg
added
the
X-Needs-Percy
Contributor
Author
Contributor
Contributor
|
Can you re-request my review once this is ready to merge? |
3 tasks
Contributor
Author
|
There are several changes to be approved on Percy tests for this PR. Please note that those changes are due to #10211, except one related to the focus issue. CC @andybalaam |
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
luixxiul
requested review from
SimonBrandner
and removed request for
kerryarchibald
luixxiul
commented
Mar 25, 2023
SimonBrandner
approved these changes
Apr 23, 2023
Contributor
SimonBrandner
left a comment
SimonBrandner
left a comment
There was a problem hiding this comment.
Looks sane
(apologies for the super late review; feel free to ping on Matrix next time :))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to tidy up
IRCLayout.pcssto clarify its structure by grouping selectors which share the same declarations, sorting declarations based onordervalue, nesting, and removing a redundant declaration.Since commits are split based on each change, reviewing per each commit should be easier than reviewing all of them at one time. Please note that there should not be an issue related to cascading which often happens when you move styles from one file to another, as this PR edits styles of just one file.
For a regression, most cases should be covered by the Cypress E2E tests.
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
type: task
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.