This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Add tests for createEditContent which mirror tests for createMessageContent.#10331
Merged
germain-gg merged 2 commits intomatrix-org:developfrom Mar 9, 2023
Merged
Add tests for createEditContent which mirror tests for createMessageContent.#10331germain-gg merged 2 commits intomatrix-org:developfrom
germain-gg merged 2 commits intomatrix-org:developfrom
Conversation
clokep
added
the
T-Task
3 tasks
florianduros
approved these changes
Mar 9, 2023
Contributor
florianduros
left a comment
florianduros
left a comment
There was a problem hiding this comment.
Thanks for tests!
FYI, a rich text editor is also available on the labs (which should replace this composer in the futur)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some tests for
createEditContent. They're essentially the tests forcreateMessageContentwith modifications to make sense for edits. This PR has no behavior changes for real code.I want to add additional tests here for #9983, but split out some basic tests first since those are unrelated (and unchanged).
Note that the last test kind of gives unexpected behavior, but I made it pass by adding the content which matrix-react-sdk generates, instead of the expected content a user would want. I don't see an open bug for this (maybe introduced in #3893 though?) and attempted to fix it quickly but did not have success.
Checklist
Sign-off given on the changes (see CONTRIBUTING.md)This change is marked as an internal change (Task), so will not be included in the changelog.