This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Add E2E test of audio player#10441
Merged
t3chguy merged 75 commits intomatrix-org:developfrom Apr 6, 2023
luixxiul:test-audioplayer
Merged
Add E2E test of audio player#10441t3chguy merged 75 commits intomatrix-org:developfrom luixxiul:test-audioplayer
t3chguy merged 75 commits intomatrix-org:developfrom
luixxiul:test-audioplayer
Conversation
- Add a long name audio file to check file name overflow - Check player layout on monospace font - Check player layout on high contrast theme - Check player layout on IRC layout (should be same as modern layout) - Percy snapshots of mx_MAudioBody (hide seekbar temporarily) - Output snapshot logs Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
…ercy tests Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
github-actions
bot
added
Z-Community-PR
luixxiul
commented
Mar 24, 2023
Contributor
Author
There was a problem hiding this comment.
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
richvdh
added
the
X-Needs-Percy
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
richvdh
approved these changes
Apr 5, 2023
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
I think this looks good, but I'd like to see what Percy does with it. Trying to find out whether we can make Percy run on this PR...
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
richvdh
reviewed
Apr 5, 2023
Member
Apparently we've run out of Percy quota, and it won't be restored until the 21st April, so I think we'll have to just go ahead and merge this |
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Contributor
Author
|
@richvdh it looks auto merge will not happen until the quota is restored. Should we wait? |
Member
Member
t3chguy
removed
the
X-Needs-Percy
Member
|
@luixxiul can you pull latest develop please |
Contributor
Author
|
I checked the latest snapshots and they have been successfully taken: https://percy.io/dfde73bd/matrix-react-sdk/builds/26747313/search?searchParam=audio%20player |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds E2E test of audio player.
For element-hq/element-web#24747 and element-hq/element-web#22542
This test includes taking Percy snapshots to check if the player is rendered properly on various scenarios (on light theme, dark theme, high contrast theme, with a reply, a reply chain, IRC layout, modern/group layout, bubble layout).
I would like to ask a reviewer to add
X-Needs-Percylabel so that I could check if the Percy tests should work as intended and fix the issue before this PR is merged and the test becomes a flaky one ondevelopbranch (I implemented several ideas which hopefully should prevent the test from becoming flaky).The Percy screenshots should be captured as below (captured manually on Cypress). Please note that the seek bar is hidden on Percy due to the flaky test reported here. Please note there is a difference between a local Cypress run and a Percy snapshot about how the list style is applied (element-hq/element-web#24969)
(Modern layout)
(bubble layout)
(modern layout)
(bubble layout)
(modern layout)
Broken: reported here
(bubble layout)
Broken: reported here
(modern layout)
(bubble layout)
(modern layout)
(bubble layout)
type: task
Retry of #10407
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.