This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Replace Sass variables with CSS custom properties - _spacing.pcss #10552
Closed
luixxiul wants to merge 13 commits intomatrix-org:developfrom
luixxiul:css-variables-spacing
Closed
Replace Sass variables with CSS custom properties - _spacing.pcss #10552luixxiul wants to merge 13 commits intomatrix-org:developfrom luixxiul:css-variables-spacing
_spacing.pcss #10552luixxiul wants to merge 13 commits intomatrix-org:developfrom
luixxiul:css-variables-spacing
Conversation
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
github-actions
bot
added
the
Z-Community-PR
github-actions
bot
added
the
T-Task
Contributor
Author
|
I re-checked by myself, and all of the spacing variables should be replaced as expected. |
Contributor
Author
|
Closing the PR in favor of #10686 Apparently this was one of the biggest wastes of time this year :-p |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For element-hq/element-web#21656
This PR intends to replace spacing Sass variables with CSS custom properties. Please note it does not change the hard-coded values as there does not seem to be a mutual agreement yet about how to deal with them (see the discussion here: #9936).
This is a low hanging fruit and should be fine for a start.
Updating this line on the style guide is going to be required.
type: task
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.