Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Remove obsolete variable and use a custom property for Slider#10779

Merged
kerryarchibald merged 3 commits intomatrix-org:developfrom
luixxiul:slider
May 9, 2023
Merged

Remove obsolete variable and use a custom property for Slider#10779
kerryarchibald merged 3 commits intomatrix-org:developfrom
luixxiul:slider

Conversation

@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 3, 2023 •
edited
Loading

This PR suggests to remove an obsolete variable and use a custom property for Slider, as a follow-up to #10473.

  • $slider-dot-size: deprecated by d2066ba

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels May 3, 2023
@luixxiul luixxiul marked this pull request as ready for review May 3, 2023 14:52
@luixxiul luixxiul requested a review from a team as a code owner May 3, 2023 14:52
@luixxiul luixxiul requested review from dbkr and kerryarchibald May 3, 2023 14:52
@dbkr
Copy link
Member

dbkr commented May 5, 2023

Looks good, you have merge conflicts now unfortunately.

@luixxiul
Copy link
Contributor Author

luixxiul commented May 5, 2023

@dbkr The conflict was fixed.

@kerryarchibald kerryarchibald added this pull request to the merge queue May 9, 2023
Merged via the queue into matrix-org:develop with commit dc9a00f May 9, 2023
@luixxiul luixxiul deleted the slider branch May 9, 2023 07:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from matrix-org/element-web-reviewers

1 more reviewer

@dbkr dbkr dbkr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luixxiul @dbkr @kerryarchibald