This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Make user role mappings configurable#11441
Closed
dhenneke wants to merge 1 commit intomatrix-org:developfrom
Closed
Make user role mappings configurable#11441dhenneke wants to merge 1 commit intomatrix-org:developfrom
dhenneke wants to merge 1 commit intomatrix-org:developfrom
Conversation
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
daddc34 to
173e115
Compare
t3chguy
reviewed
Aug 21, 2023
| RoomHistorySettings = "UIFeature.roomHistorySettings", | ||
| TimelineEnableRelativeDates = "UIFeature.timelineEnableRelativeDates", | ||
| BulkUnverifiedSessionsReminder = "UIFeature.BulkUnverifiedSessionsReminder", | ||
| CustomPowerLevel = "UIFeature.customPowerLevel", |
Member
There was a problem hiding this comment.
Contributor
|
I've updated the time sheeting label on this pull request. Reviewers, please take this into account when filling your sheets. |
Contributor
|
Based on our chat on Matrix, I'm going to assume that overriding the translations of the existing roles will be sufficient for your needs for now and that we can avoid polluting the config / module API until the larger problem is solved on the spec level. The fixes to unbreak the latter should be landing this week (matrix-org/matrix-web-i18n#13, matrix-org/matrix-react-sdk-module-api#20, #11685 & element-hq/element-web#26262). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to be able to specify new role labels for power levels. This goes beyond renaming them (->
custom_translations_urlor module system) and relates to matrix-org/matrix-react-sdk-module-api#6. There are different MSC proposal but nothing agreed upon, yet, so we would like to introduce a Client-global configuration until a more flexible and standardised solution will become available eventually. This assumes that all rooms in a controlled Element/Synapse installation use the same roles.We create a new setting
custom_power_level_roles(it could also be acustom_power_level_roles_urlif you would prefer that):This PR also adds
UIFeature.customPowerLevelin order to hide the "Custom Level" option that might be discouraged in certain environments:This is used in the following places:
It's not used in the people list, yet, because I'm not sure what the intention there is. It looks like this explicitly uses short-forms of the labels to better fit in the sidebar so we can't just use the labels from above.
We could do:
{ "custom_power_level_roles": { "0": { "label": { "en": "Noob", "de": "Niemand", }, "short_label": { /* no label */ }, }, "25": { "label": { "en": "Crew", "de": "Mannschaft" }, "short_label": { "en": "Crew" } }, // ... } }but I would be happy about some feedback.
Checklist
Type: enhancement
Here's what your changelog entry will look like:
✨ Features