This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Track the user's own typing state external to the composer#3150
Merged
Track the user's own typing state external to the composer#3150
Conversation
Fixes element-hq/element-web#9986 There's a few reasons for pushing this out to its own place: * In future, we might want to move WhoIsTyping here. * We have multiple composers now, and although they don't send typing notifications, they could (see https://github.com/vector-im/riot-web/issues/10188) * In future we may have status for where/what the user is typing (https://github.com/matrix-org/matrix-doc/issues/437) * The composer is complicated enough - it doesn't need to dedupe typing states too. Note: This makes use of the principles introduced in element-hq/element-web#8923 and element-hq/element-web#9090
bwindels
approved these changes
Jun 27, 2019
Contributor
bwindels
left a comment
bwindels
left a comment
There was a problem hiding this comment.
looks good! Would be nice to also move the typing timeout logic from the composer here and have a method you can hammer without needing to think about it from the composer, but this is a great start :
bwindels
suggested changes
Jun 28, 2019
Contributor
bwindels
left a comment
bwindels
left a comment
There was a problem hiding this comment.
Thanks for the changes! Looks nicer indeed with the Timer, just need to not await the promise (potentially) multiple times.
bwindels
approved these changes
Jul 3, 2019
Contributor
bwindels
left a comment
bwindels
left a comment
There was a problem hiding this comment.
lost track of this, sorry! lgtm (although no reason to duplicate the restart call, so assuming that's a stylistic choice 👍 :)
Member
Author
|
It's stylistic in that I never want to forget that it was called, even if it gets accidentally refactored out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#9986
There's a few reasons for pushing this out to its own place:
Note: This makes use of the principles introduced in element-hq/element-web#8923 and element-hq/element-web#9090