This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Expose power level toggle for enabling e2ee to room settings#3351
Merged
Expose power level toggle for enabling e2ee to room settings#3351
Conversation
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
turt2live
changed the title
turt2live
suggested changes
Aug 28, 2019
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
It should be disabled if encryption is already enabled
Member
Author
This is kind-of already an issue already if someone changes the PL required for enabling E2EE riot will show it in settings anyway, the wording is just a bit less ambiguous after this change |
…atrix-org/matrix-react-sdk into t3chguy/pl_control_e2e � Conflicts: � src/components/views/settings/tabs/room/RolesRoomSettingsTab.js � src/i18n/strings/en_EN.json
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
turt2live
approved these changes
Aug 30, 2019
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
hiding is indeed better, I think. The whole power levels page is due for a redesign anyhow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#10463
Signed-off-by: Michael Telatynski 7t3chguy@gmail.com