This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fixed misaligned reply preview in thread composer.#9733
Closed
ashwat287 wants to merge 1 commit intomatrix-org:developfrom
Closed
Fixed misaligned reply preview in thread composer.#9733ashwat287 wants to merge 1 commit intomatrix-org:developfrom
ashwat287 wants to merge 1 commit intomatrix-org:developfrom
Conversation
Signed-off-by: NerdyLucifer <ashwatpas@gmail.com>
github-actions
bot
added
Z-Community-PR
germain-gg
suggested changes
Dec 12, 2022
Contributor
germain-gg
left a comment
germain-gg
left a comment
There was a problem hiding this comment.
Thank you for your first contribution, looks great!
If we can ensure correctness in the main room timeline too, we should be able to land this change.
| background: $background; | ||
| max-height: 50vh; | ||
| overflow: auto; | ||
| margin: 0 0 0 -8px; |
Contributor
There was a problem hiding this comment.
This will shift the reply preview left by 8 pixels in all scenarios.
That might create a visual regression in the main room timeline too. Could you add some screenshots for that context too so we can validate whether it looks adequate.
We also tend to use $spacing-8 rather than hardcoding a value. calc(-1 * $spacing-8) should achieve the same result here
3 tasks
Contributor
|
Other PR targeting the same issue: #9977 |
Contributor
|
@NerdyLucifer unfortunately someone else was faster than you 😐 Closing in favour of #9977 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: NerdyLucifer ashwatpas@gmail.com
Fixes: element-hq/element-web/issues/23396
Type: Defect
Checklist
element-web notes: Fixed misaligned reply preview in thread composer.
Here's what your changelog entry will look like:
🐛 Bug Fixes