Conversation
We stick it in a client section of v1 as the earliest version to define the algorithm is v1, and the client-server spec tells clients to use this algorithm.
This feels like it was a mistake some time ago considering the redaction algorithm is used in very strict algorithms like event signing.
MSC: #2209 The changes are slightly difficult to word without dumping the text in and playing a game of spot the difference, so we now use our pre-existing pygments support to render a representation of the difference. The difference is shown in markdown-like format instead of RST for ease of understanding. It's also not rendered HTML for largely complexity reasons.
This was referenced May 21, 2020
turt2live
added
next-release
Member
Author
|
Implementation for all this is linked off from matrix-org/synapse#7500 |
anoadragon453
approved these changes
May 26, 2020
Member
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
Lgtm other than the couple nits below. Diff colorization is cool too.
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
anoadragon453
approved these changes
May 26, 2020
Member
Author
|
(will land this when the release scripts are ready, as merging this immediately puts it live and we have to update the index anyways) |
19 tasks
richvdh
added
merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1727
Reviewing this commit-by-commit might be best as it tells a bit of a story.
MSCs implemented:
Note: Most of MSC2432 is specified in #2562