MSC3279: Expose enable_set_displayname in capabilities response #3279
Closed
JonasKress wants to merge 4 commits intomasterfrom
Closed
MSC3279: Expose enable_set_displayname in capabilities response #3279JonasKress wants to merge 4 commits intomasterfrom
JonasKress wants to merge 4 commits intomasterfrom
Conversation
JonasKress
added
proposal
KitsuneRal
requested changes
Jul 13, 2021
Member
KitsuneRal
left a comment
KitsuneRal
left a comment
There was a problem hiding this comment.
Looks very straightforward and uncontroversial. As a client author, I definitely see a value from exposing it (even though I don't sit on homeservers with enable_set_displayname: false). A few suggestions below.
dklimpel
reviewed
Jul 13, 2021
Contributor
Co-authored-by: Alexey Rusakov <Kitsune-Ral@users.sf.net>
Co-authored-by: Alexey Rusakov <Kitsune-Ral@users.sf.net>
turt2live
changed the title
turt2live
reviewed
Jul 13, 2021
turt2live
added
kind:feature
…-enable_set_displayname-capabilities.md
Contributor
Author
|
New pull request as branch was rename |
turt2live
added
obsolete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered