Skip to content

MSC3291: Muting in VoIP calls #3291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turt2live merged 22 commits into from
Jul 16, 2023
Merged

MSC3291: Muting in VoIP calls #3291

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
78bfa25
MSC: Muting in VoIP calls
SimonBrandner Jul 22, 2021
a3d1abc
Update MSC number
SimonBrandner Jul 22, 2021
57a6330
Missing :
SimonBrandner Jul 22, 2021
7658c4a
Fix MSC number in prefix
SimonBrandner Jul 22, 2021
2130df9
Fix unstable prefix table
SimonBrandner Jul 23, 2021
3a9701d
Reword pottential issues
SimonBrandner Jul 23, 2021
d809c3b
Add an Alternatives section
SimonBrandner Jul 23, 2021
67168b3
Remove trailing comma
SimonBrandner Jul 26, 2021
ec24d95
Fix a typo
SimonBrandner Jul 26, 2021
0c01908
Fix missing word
SimonBrandner Jul 26, 2021
cc8b73a
Link to MSC for holding
SimonBrandner Jul 26, 2021
f1ac61f
Update unstable prefixes
SimonBrandner Jul 27, 2021
29e3c6d
Simplify things
SimonBrandner Jan 10, 2023
5372b7f
Be explicit about deps
SimonBrandner May 11, 2023
00da3d3
Be clearer about how things work
SimonBrandner May 11, 2023
fb8f957
Update proposals/3291-muting.md
SimonBrandner Jun 11, 2023
c97f650
`disabled` -> `enabled`
SimonBrandner Jun 11, 2023
1aa2cd4
Fix client mention
SimonBrandner Jun 11, 2023
dec84a8
Improve explaination
SimonBrandner Jun 11, 2023
56d3541
Be more precise
SimonBrandner Jul 3, 2023
8905378
Fix negation
SimonBrandner Jul 3, 2023
4da6f86
Don't refer to something that doesn't exist
SimonBrandner Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Link to MSC for holding 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
  • Loading branch information
@SimonBrandner
SimonBrandner committed Jul 26, 2021
commit cc8b73ae846f590d4a3f09ed1586397e9ea39d0a
3 changes: 2 additions & 1 deletion proposals/3291-muting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,8 @@ we ever decided to do what is described in the next section.

An option would be using the current method in combination with setting the
corresponding track as `recvonly`/`inactive`. Along with this clients would need
to set the mute state in `sdp_stream_metadata` to avoid conflicts with holding.
to set the mute state in `sdp_stream_metadata` to avoid conflicts with holding
(as defined in [MSC2746](https://github.com/matrix-org/matrix-doc/pull/2746)).
While this solution might be the most flexible solution as it would allow
clients to choose between bandwidth and a mute state change delay for each
track, it would be harder to implement and feels generally disjointed.
Copy link
Contributor

@bwindels bwindels Apr 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure we don't want to go for optimal bandwidth usage? I personally often turn off video to have more bandwidth available for audio when the quality is terrible. Feels unfortunate to exclude this. Also, this doesn't feel much harder to implement.

Copy link
Contributor

@bwindels bwindels Apr 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this further, why not remove the track entirely and send a m.call.negotiate event with the metadata update rather than just set the direction of the transceiver? It's kind of annoying that the webcam light doesn't turn off when you mute your video.

Copy link
Contributor

@kevincox kevincox Apr 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be the choice of the client. In general not sending the video when video is off makes sense. The extra latency of starting up the stream is usually quite small and the bandwidth savings is significant which can make a huge difference for someone on a connection that struggle to send audio and video but can support audio reliably. Turning off the camera is less often used because actually getting a new stream from the camera can have very high and unpredictable latency depending on the hardware or the OS. Probably a good client will have a variety of heuristics to decide how far to shut down the camera but the key thing from the spec point of view that completely turning off the camera is possible if desired.

Copy link
Contributor Author

@SimonBrandner SimonBrandner Apr 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I stand against going with both options at the same time - let the client choose. @dbkr, would you agree?

Copy link
Contributor Author

@SimonBrandner SimonBrandner Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, we do this now: matrix-org/matrix-js-sdk#3028

Copy link
Member

@dbkr dbkr May 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I believe Enrico recently discovered with his experiments that browsers (at least some of them) now send nothing when a video track is disabled, so the bandwidth argument is even less relevant. Turning cameras off is orthogonal and can be done whether or not you remove the video track. The negotiate mechanism still exists either way.

Copy link
Contributor Author

@SimonBrandner SimonBrandner May 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe Enrico recently discovered with his experiments that browsers (at least some of them) now send nothing when a video track is disabled, so the bandwidth argument is even less relevant

Is this documented anywhere?

Copy link
Member

@anoadragon453 anoadragon453 May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the MSC need to be updated given the conclusions drawn here?

Copy link
Member

@anoadragon453 anoadragon453 Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to assume not and resolve this thread. Please re-open if you believe otherwise.

Expand Down