Skip to content

MSC3604: Room Version 10#3604

Merged
turt2live merged 7 commits intomainfrom
travis/msc/v10
May 29, 2022
Merged

MSC3604: Room Version 10#3604
turt2live merged 7 commits intomainfrom
travis/msc/v10

Conversation

@turt2live
Copy link
Member

@turt2live turt2live commented Dec 29, 2021 •
edited
Loading

@turt2live turt2live added blocked Something needs to be done before action can be taken on this PR/issue. kind:core MSC which is critical to the protocol's success proposal A matrix spec change proposal room-spec Something to do with the room version specifications labels Dec 29, 2021
@turt2live turt2live mentioned this pull request Dec 29, 2021
Closed
4 tasks
@turt2live turt2live added the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Dec 31, 2021
@neilalexander
Copy link
Contributor

neilalexander commented Jan 24, 2022

Can I propose adding #3667? Seems like a good bug fix to get in.

Mikaela
Mikaela reviewed Feb 3, 2022
View reviewed changes
@Mikaela Mikaela mentioned this pull request Feb 21, 2022
Closed
@turt2live turt2live mentioned this pull request Mar 25, 2022
Open
@turt2live turt2live mentioned this pull request May 4, 2022
Closed
@turt2live turt2live removed blocked Something needs to be done before action can be taken on this PR/issue. needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels May 4, 2022
@turt2live turt2live changed the title [WIP: Not ready for review/impl] MSC3604: Room Version 10 MSC3604: Room Version 10 May 4, 2022
@turt2live turt2live mentioned this pull request May 4, 2022
Merged
@turt2live
Copy link
Member Author

turt2live commented May 4, 2022

This MSC is now ready for review. Once MSC3787 clears FCP (or reasonably looks like it will clear FCP), this MSC will be sent up for FCP.

@turt2live turt2live marked this pull request as ready for review May 4, 2022 03:10
This was referenced May 4, 2022
Merged
Merged
turt2live
turt2live commented May 4, 2022
View reviewed changes
@Mikaela Mikaela mentioned this pull request May 6, 2022
Open
@turt2live turt2live mentioned this pull request May 16, 2022
Closed
15 tasks
@mscbot
Copy link
Collaborator

mscbot commented May 20, 2022 •
edited by richvdh
Loading

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added disposition-merge proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels May 20, 2022
@mscbot
Copy link
Collaborator

mscbot commented May 24, 2022

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels May 24, 2022
@turt2live turt2live self-assigned this May 24, 2022
@mscbot
Copy link
Collaborator

mscbot commented May 29, 2022

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels May 29, 2022
@turt2live turt2live merged commit 46ae237 into main May 29, 2022
@turt2live turt2live deleted the travis/msc/v10 branch May 29, 2022 16:07
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels May 29, 2022
@neilalexander neilalexander mentioned this pull request May 30, 2022
Merged
@turt2live turt2live mentioned this pull request May 30, 2022
Merged
@turt2live
Copy link
Member Author

turt2live commented May 30, 2022

Spec PR: matrix-org/matrix-spec#1099

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels May 30, 2022
@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jun 8, 2022
@turt2live
Copy link
Member Author

turt2live commented Jun 8, 2022

Merged 🎉

This was referenced Jun 10, 2022
Closed
Closed
This was referenced Jun 21, 2022
Merged
Merged
@anoadragon453 anoadragon453 restored the travis/msc/v10 branch September 27, 2022 16:59
@S7evinK S7evinK mentioned this pull request Sep 29, 2023
Open
16 tasks
@matrixbot matrixbot mentioned this pull request Nov 1, 2024
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Mikaela Mikaela Mikaela left review comments

@jplatte jplatte jplatte left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@turt2live turt2live

Labels

kind:core MSC which is critical to the protocol's success merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal room-spec Something to do with the room version specifications

Projects

Spec Core Team Workflow
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@turt2live @neilalexander @mscbot @Mikaela @jplatte