Clarify that invite->knock is *not* a valid transition#1717
Merged
turt2live merged 1 commit intomatrix-org:mainfrom Feb 21, 2024
Merged
Clarify that invite->knock is *not* a valid transition#1717turt2live merged 1 commit intomatrix-org:mainfrom
turt2live merged 1 commit intomatrix-org:mainfrom
Conversation
richvdh
changed the title
richvdh
approved these changes
Jan 25, 2024
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
As with matrix-org/matrix-spec-proposals#4091: I think this is the right thing to do, but I would like opinions from others.
Member
|
/cc @deepbluev7 and @Gnuxie on this as well |
Member
|
Also worth linking here: a complement test that asserts that what is implemented matches what this PR says: matrix-org/complement#702. |
dbkr
approved these changes
Jan 25, 2024
Member
dbkr
left a comment
dbkr
left a comment
There was a problem hiding this comment.
Thanks, I agree this is the correct way out of the mess, and doubly so with the complement test.
This was referenced Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #1175
See #1710
Signed-off-by: Kegan Dougal kegan@matrix.org
Preview: https://pr1717--matrix-spec-previews.netlify.app