Skip to content

Clarify the meaning of "public rooms" in the room directory#2104

Merged
richvdh merged 11 commits intomatrix-org:mainfrom
Johennes:johannes/public-rooms-room-directory
May 21, 2025
Merged

Clarify the meaning of "public rooms" in the room directory#2104
richvdh merged 11 commits intomatrix-org:mainfrom
Johennes:johannes/public-rooms-room-directory

Conversation

@Johennes
Copy link
Contributor

@Johennes Johennes commented Mar 19, 2025

Relates to: #633

Pull Request Checklist

Preview: https://pr2104--matrix-spec-previews.netlify.app

Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@Johennes Johennes marked this pull request as ready for review March 19, 2025 14:00
@Johennes Johennes requested a review from a team as a code owner March 19, 2025 14:00
Co-authored-by: Kim Brose <2803622+HarHarLinks@users.noreply.github.com>
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor notes, otherwise this looks good to me. Thank you!

I'd also like to explicitly highlight the transition from "public room directory" to "published room directory" as being one the ecosystem will need to adapt to. And if you could just audit the diff to make sure we're using "published room directory" vs. "room directory" in all the right places.

Johennes and others added 4 commits May 21, 2025 09:15
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@Johennes
Copy link
Contributor Author

Johennes commented May 21, 2025

I'd also like to explicitly highlight the transition from "public room directory" to "published room directory" as being one the ecosystem will need to adapt to.

I'm slightly unsure how exactly to reflect this in the spec text. Or did you just mean calling it out explicitly in the changelog?

And if you could just audit the diff to make sure we're using "published room directory" vs. "room directory" in all the right places.

Have changed the wording accordingly in all applicable places with 9f17ab0.

@Johennes Johennes requested a review from anoadragon453 May 21, 2025 07:58
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@richvdh richvdh merged commit 2c734c3 into matrix-org:main May 21, 2025
12 checks passed
Johennes added a commit to Johennes/matrix-spec that referenced this pull request May 30, 2025
…rg#2104)

Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Co-authored-by: Kim Brose <2803622+HarHarLinks@users.noreply.github.com>
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@Johennes Johennes mentioned this pull request Jul 3, 2025
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants