Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Use StrCollection in more places #14809

@clokep

Description

@clokep

Using a Sequence[str] or Collection[str] is bad since a str also fits those and you usually want this to refer to a Set[str], List[str], Tuple[str, ...], etc.

In #14716 @reivilibre added a StrCollection type which we can re-use for this.

This has bit us a few times in the past but I'm failing to find references at the moment.

It would be good to audit Sequence[str] and Collection[str] and see if any of those should be updated.

Metadata

Metadata

Assignees

No one assigned

    Labels

    O-OccasionalAffects or can be seen by some users regularly or most users rarelyS-MinorBlocks non-critical functionality, workarounds exist.T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.Z-CleanupThings we want to get rid of, but aren't actively causing pain

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions