Clarify `(room_id, event_id)` global uniqueness by MadLittleMods · Pull Request #13701 · matrix-org/synapse

MadLittleMods · 2022-09-01T22:16:21Z

Clarify (room_id, event_id) global uniqueness

Summarized from @richvdh's reply at #13589 (comment)

Pull Request Checklist

Pull request is based on the develop branch
Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
- Use markdown where necessary, mostly for code blocks.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
~~Pull request includes a sign off~~
Code style is correct
(run the linters)

@richvdh

Summarized from @richvdh's reply at #13589 (comment)

docs/development/database_schema.md

reivilibre · 2022-09-02T11:11:05Z

docs/development/database_schema.md

+
+There are several places in Synapse and even Matrix API's like [`GET
+/_matrix/federation/v1/event/{eventId}`](https://spec.matrix.org/v1.1/server-server-api/#get_matrixfederationv1eventeventid)
+where we assume that event IDs are globally unique.


this seems rather sad considering they are very much not and it's not very hard to cause a conflict :/

We can hope for MSC2848 🙌

reivilibre · 2022-09-02T11:14:36Z

docs/development/database_schema.md

+/_matrix/federation/v1/event/{eventId}`](https://spec.matrix.org/v1.1/server-server-api/#get_matrixfederationv1eventeventid)
+where we assume that event IDs are globally unique.
+
+But hash collisions are still possible, and by treating event IDs as room


I actually think hash collisions from sheer probability are not much of a justifiable problem (maybe SHA256 will get defeated one day I suppose...?)
SHA256 is 256-bit, so only once you have 2^128 events would you have 0.5 probability of having a collision. That's way more events than I think anyone will ever store.

I expect the main problem is probably intentional collisions (esp in v1 rooms), where namespacing events by room means that we don't let a bad actor interfere with any rooms they're not in.

maybe SHA256 will get defeated one day I suppose...?

🤷 Probably, maybe

The rest of my reply is just linking stuff from my own curiosity:

SHA-1 attack, https://github.blog/2017-03-20-sha-1-collision-detection-on-github-com/

Other reading:

https://crypto.stackexchange.com/questions/47809/why-havent-any-sha-256-collisions-been-found-yet

https://crypto.stackexchange.com/questions/52578/are-there-any-well-known-examples-of-sha-256-collisions

I expect the main problem is probably intentional collisions (esp in v1 rooms), where namespacing events by room means that we don't let a bad actor interfere with any rooms they're not in.

https://spec.matrix.org/v1.1/rooms/v3/#event-ids

I'm a bit confused about where we've ended up on this thread: are hash collisions (feasibly) possible or not?

Room v1 and v2 have bigger problems than event-id clashes between rooms. The solution to that is to stop using v1 and v2 rooms, not to arrange the entire database schema and matrix API around a half-assed fix to it.

are hash collisions (feasibly) possible or not?

Probably not feasible but I wouldn't rule it out one day.

[...] not to arrange the entire database schema and matrix API around a half-assed fix to it.

I'm confused by this. Do we prefer (room_id, event_id) or not?

Do we prefer (room_id, event_id) or not?

That's the entire discussion here, and I don't think we have a clear conclusion. Personally, I don't really see the point in including room_id in the constraint, but mostly I'd rather we have a discussion on it than just merge a PR which takes one particular view, and justifies it using questionable arguments.

this PR said: "we should prefer (room_id, event_id) because of hash collisions"

@reivilibre's review appeared to say "actually, hash collisions are infeasible"

And yet the PR is still merged, saying that the reason to prefer (room_id, event_id) is to avoid hash collisions.

It was discussed in the backend chapter sync as well which also brought up #13771.

@reivilibre's review appeared to say "actually, hash collisions are infeasible"

And yet the PR is still merged, saying that the reason to prefer (room_id, event_id) is to avoid hash collisions.

This PR captures the tribal knowledge you mentioned in,

Hash collisions are possible, and by treating event IDs as room scoped, we could reduce the possibility of a hash collision.

-- @richvdh, #13589 (comment)

@reivilibre's number investigation is a good enough to disprove the sheer chance that a client and server run into a collision. I'm less convinced there won't be a way to exploit things in the future (targeted attack) but we can update this part of the doc to not call it out as much.

well, we probably need to discuss this further when I'm back from leave. #12892 moves in exactly the opposite direction to that suggested here.

Co-authored-by: reivilibre <oliverw@matrix.org>

docs/development/database_schema.md

MadLittleMods · 2022-09-02T19:05:56Z

Thanks for the review @reivilibre 🐗

@Vetchu

Synapse 1.67.0 (2022-09-13) =========================== This release removes using the deprecated direct TCP replication configuration for workers. Server admins should use Redis instead. See the [upgrade notes](https://matrix-org.github.io/synapse/v1.67/upgrade.html#upgrading-to-v1670). The minimum version of `poetry` supported for managing source checkouts is now 1.2.0. **Notice:** from the next major release (1.68.0) installing Synapse from a source checkout will require a recent Rust compiler. Those using packages or `pip install matrix-synapse` will not be affected. See the [upgrade notes](https://matrix-org.github.io/synapse/v1.67/upgrade.html#upgrading-to-v1670). **Notice:** from the next major release (1.68.0), running Synapse with a SQLite database will require SQLite version 3.27.0 or higher. (The [current minimum version is SQLite 3.22.0](https://github.com/matrix-org/synapse/blob/release-v1.67/synapse/storage/engines/sqlite.py#L69-L78).) See [matrix-org#12983](matrix-org#12983) and the [upgrade notes](https://matrix-org.github.io/synapse/v1.67/upgrade.html#upgrading-to-v1670) for more details. No significant changes since 1.67.0rc1. Synapse 1.67.0rc1 (2022-09-06) ============================== Features -------- - Support setting the registration shared secret in a file, via a new `registration_shared_secret_path` configuration option. ([\matrix-org#13614](matrix-org#13614)) - Change the default startup behaviour so that any missing "additional" configuration files (signing key, etc) are generated automatically. ([\matrix-org#13615](matrix-org#13615)) - Improve performance of sending messages in rooms with thousands of local users. ([\matrix-org#13634](matrix-org#13634)) Bugfixes -------- - Fix a bug introduced in Synapse 1.13 where the [List Rooms admin API](https://matrix-org.github.io/synapse/develop/admin_api/rooms.html#list-room-api) would return integers instead of booleans for the `federatable` and `public` fields when using a Sqlite database. ([\matrix-org#13509](matrix-org#13509)) - Fix bug that user cannot `/forget` rooms after the last member has left the room. ([\matrix-org#13546](matrix-org#13546)) - Faster Room Joins: fix `/make_knock` blocking indefinitely when the room in question is a partial-stated room. ([\matrix-org#13583](matrix-org#13583)) - Fix loading the current stream position behind the actual position. ([\matrix-org#13585](matrix-org#13585)) - Fix a longstanding bug in `register_new_matrix_user` which meant it was always necessary to explicitly give a server URL. ([\matrix-org#13616](matrix-org#13616)) - Fix the running of [MSC1763](matrix-org/matrix-spec-proposals#1763) retention purge_jobs in deployments with background jobs running on a worker by forcing them back onto the main worker. Contributed by Brad @ Beeper. ([\matrix-org#13632](matrix-org#13632)) - Fix a long-standing bug that downloaded media for URL previews was not deleted while database background updates were running. ([\matrix-org#13657](matrix-org#13657)) - Fix [MSC3030](matrix-org/matrix-spec-proposals#3030) `/timestamp_to_event` endpoint to return the correct next event when the events have the same timestamp. ([\matrix-org#13658](matrix-org#13658)) - Fix bug where we wedge media plugins if clients disconnect early. Introduced in v1.22.0. ([\matrix-org#13660](matrix-org#13660)) - Fix a long-standing bug which meant that keys for unwhitelisted servers were not returned by `/_matrix/key/v2/query`. ([\matrix-org#13683](matrix-org#13683)) - Fix a bug introduced in Synapse v1.20.0 that would cause the unstable unread counts from [MSC2654](matrix-org/matrix-spec-proposals#2654) to be calculated even if the feature is disabled. ([\matrix-org#13694](matrix-org#13694)) Updates to the Docker image --------------------------- - Update docker image to use a stable version of poetry. ([\matrix-org#13688](matrix-org#13688)) Improved Documentation ---------------------- - Improve the description of the ["chain cover index"](https://matrix-org.github.io/synapse/latest/auth_chain_difference_algorithm.html) used internally by Synapse. ([\matrix-org#13602](matrix-org#13602)) - Document how ["monthly active users"](https://matrix-org.github.io/synapse/latest/usage/administration/monthly_active_users.html) is calculated and used. ([\matrix-org#13617](matrix-org#13617)) - Improve documentation around user registration. ([\matrix-org#13640](matrix-org#13640)) - Remove documentation of legacy `frontend_proxy` worker app. ([\matrix-org#13645](matrix-org#13645)) - Clarify documentation that HTTP replication traffic can be protected with a shared secret. ([\matrix-org#13656](matrix-org#13656)) - Remove unintentional colons from [config manual](https://matrix-org.github.io/synapse/latest/usage/configuration/config_documentation.html) headers. ([\matrix-org#13665](matrix-org#13665)) - Update docs to make enabling metrics more clear. ([\matrix-org#13678](matrix-org#13678)) - Clarify `(room_id, event_id)` global uniqueness and how we should scope our database schemas. ([\matrix-org#13701](matrix-org#13701)) Deprecations and Removals ------------------------- - Drop support for calling `/_matrix/client/v3/rooms/{roomId}/invite` without an `id_access_token`, which was not permitted by the spec. Contributed by @Vetchu. ([\matrix-org#13241](matrix-org#13241)) - Remove redundant `_get_joined_users_from_context` cache. Contributed by Nick @ Beeper (@Fizzadar). ([\matrix-org#13569](matrix-org#13569)) - Remove the ability to use direct TCP replication with workers. Direct TCP replication was deprecated in Synapse v1.18.0. Workers now require using Redis. ([\matrix-org#13647](matrix-org#13647)) - Remove support for unstable [private read receipts](matrix-org/matrix-spec-proposals#2285). ([\matrix-org#13653](matrix-org#13653), [\matrix-org#13692](matrix-org#13692)) Internal Changes ---------------- - Extend the release script to wait for GitHub Actions to finish and to be usable as a guide for the whole process. ([\matrix-org#13483](matrix-org#13483)) - Add experimental configuration option to allow disabling legacy Prometheus metric names. ([\matrix-org#13540](matrix-org#13540)) - Cache user IDs instead of profiles to reduce cache memory usage. Contributed by Nick @ Beeper (@Fizzadar). ([\matrix-org#13573](matrix-org#13573), [\matrix-org#13600](matrix-org#13600)) - Optimize how Synapse calculates domains to fetch from during backfill. ([\matrix-org#13575](matrix-org#13575)) - Comment about a better future where we can get the state diff between two events. ([\matrix-org#13586](matrix-org#13586)) - Instrument `_check_sigs_and_hash_and_fetch` to trace time spent in child concurrent calls for understandable traces in Jaeger. ([\matrix-org#13588](matrix-org#13588)) - Improve performance of `@cachedList`. ([\matrix-org#13591](matrix-org#13591)) - Minor speed up of fetching large numbers of push rules. ([\matrix-org#13592](matrix-org#13592)) - Optimise push action fetching queries. Contributed by Nick @ Beeper (@Fizzadar). ([\matrix-org#13597](matrix-org#13597)) - Rename `event_map` to `unpersisted_events` when computing the auth differences. ([\matrix-org#13603](matrix-org#13603)) - Refactor `get_users_in_room(room_id)` mis-use with dedicated `get_current_hosts_in_room(room_id)` function. ([\matrix-org#13605](matrix-org#13605)) - Use dedicated `get_local_users_in_room(room_id)` function to find local users when calculating `join_authorised_via_users_server` of a `/make_join` request. ([\matrix-org#13606](matrix-org#13606)) - Refactor `get_users_in_room(room_id)` mis-use to lookup single local user with dedicated `check_local_user_in_room(...)` function. ([\matrix-org#13608](matrix-org#13608)) - Drop unused column `application_services_state.last_txn`. ([\matrix-org#13627](matrix-org#13627)) - Improve readability of Complement CI logs by printing failure results last. ([\matrix-org#13639](matrix-org#13639)) - Generalise the `@cancellable` annotation so it can be used on functions other than just servlet methods. ([\matrix-org#13662](matrix-org#13662)) - Introduce a `CommonUsageMetrics` class to share some usage metrics between the Prometheus exporter and the phone home stats. ([\matrix-org#13671](matrix-org#13671)) - Add some logging to help track down matrix-org#13444. ([\matrix-org#13679](matrix-org#13679)) - Update poetry lock file for v1.2.0. ([\matrix-org#13689](matrix-org#13689)) - Add cache to `is_partial_state_room`. ([\matrix-org#13693](matrix-org#13693)) - Update the Grafana dashboard that is included with Synapse in the `contrib` directory. ([\matrix-org#13697](matrix-org#13697)) - Only run trial CI on all python versions on non-PRs. ([\matrix-org#13698](matrix-org#13698)) - Fix typechecking with latest types-jsonschema. ([\matrix-org#13712](matrix-org#13712)) - Reduce number of CI checks we run for PRs. ([\matrix-org#13713](matrix-org#13713)) # -----BEGIN PGP SIGNATURE----- # # iQFEBAABCgAuFiEEBTGR3/RnAzBGUif3pULk7RsPrAkFAmMgR2QQHGVyaWtAbWF0 # cml4Lm9yZwAKCRClQuTtGw+sCfG7B/94PwW1ChsaI8hkz/3e+93PEl/mNJ6YFaEB # 5pP4Dh/0dipP/iKbpgNuj5xz/JFnIi8D49A8sKNnku3jk0/8AZHgqDiBgOkrN76z # Y3awo5Q9ag4xww/105V3bhdnX1NrX8Avf6F2jchDv6/9q8wQHGBPg6DMgfZ/m/BL # SB4dypbbNpgLykuwtWxx6YMUYH+trsXJOn/MoAqld3QcZsqkDR25wXCt9+Dr+6AT # dPd/czi8kV8ruU59tf2K5HB7XKzBW9S3Qb3dJJmGOTTJ7ccUkN/XuTwqnII950Mo # bSlMXjY2hqk8rKUNhGZpi9bqUkwNhMgOkZl9A0Y1XtsXx6yjy0T/ # =zSGi # -----END PGP SIGNATURE----- # gpg: Signature made Tue Sep 13 10:03:32 2022 BST # gpg: using RSA key 053191DFF4670330465227F7A542E4ED1B0FAC09 # gpg: issuer "erik@matrix.org" # gpg: Can't check signature: No public key # Conflicts: # synapse/config/experimental.py # synapse/push/bulk_push_rule_evaluator.py # synapse/storage/databases/main/event_push_actions.py # synapse/util/caches/descriptors.py

Follow-up to: - #13701 - #13771

…13915) * Emphasize the right reasons to use (room_id, event_id) Follow-up to: - #13701 - #13771

Clarify (room_id, event_id) uniqueness

25fa1c4

Summarized from @richvdh's reply at #13589 (comment)

MadLittleMods added A-Docs things relating to the documentation T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. labels Sep 1, 2022

Add changelog

14c1dd5

MadLittleMods mentioned this pull request Sep 1, 2022

Keep track when we try and fail to process a pulled event #13589

Merged

5 tasks

Merge branch 'develop' into madlittlemods/event-id-room-id-uniqueness

4fb453f

MadLittleMods marked this pull request as ready for review September 1, 2022 22:19

MadLittleMods requested a review from a team as a code owner September 1, 2022 22:19

MadLittleMods mentioned this pull request Sep 1, 2022

Only try to backfill event if we haven't tried before recently (exponential backoff) #13635

Merged

11 tasks

reivilibre approved these changes Sep 2, 2022

View reviewed changes

No apostrophe needed

5dd24f3

Co-authored-by: reivilibre <oliverw@matrix.org>

MadLittleMods commented Sep 2, 2022

View reviewed changes

docs/development/database_schema.md Outdated Show resolved Hide resolved

Put the uniqueness in the right context

893d4c5

MadLittleMods merged commit 877bdfa into develop Sep 2, 2022

MadLittleMods deleted the madlittlemods/event-id-room-id-uniqueness branch September 2, 2022 19:05

MadLittleMods mentioned this pull request Sep 9, 2022

Document easy room purge benefit of using (room_id, event_id) #13771

Closed

4 tasks

MadLittleMods added a commit that referenced this pull request Sep 26, 2022

Emphasize the right reasons to use (room_id, event_id)

563cb35

Follow-up to: - #13701 - #13771

MadLittleMods mentioned this pull request Sep 26, 2022

Emphasize the right reasons to use (room_id, event_id) in a schema #13915

Merged

4 tasks

richvdh pushed a commit that referenced this pull request Sep 27, 2022

Emphasize the right reasons to use (room_id, event_id) in a schema (#…

35e9d6a

…13915) * Emphasize the right reasons to use (room_id, event_id) Follow-up to: - #13701 - #13771

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Clarify `(room_id, event_id)` global uniqueness#13701

Clarify `(room_id, event_id)` global uniqueness#13701
MadLittleMods merged 5 commits intodevelopfrom
madlittlemods/event-id-room-id-uniqueness

MadLittleMods commented Sep 1, 2022 •

edited

Loading

Uh oh!

Uh oh!

reivilibre Sep 2, 2022

Uh oh!

MadLittleMods Sep 2, 2022 •

edited

Loading

Uh oh!

reivilibre Sep 2, 2022

Uh oh!

MadLittleMods Sep 2, 2022

Uh oh!

richvdh Sep 6, 2022

Uh oh!

MadLittleMods Sep 6, 2022

Uh oh!

richvdh Sep 14, 2022

Uh oh!

MadLittleMods Sep 14, 2022 •

edited

Loading

Uh oh!

richvdh Sep 18, 2022 •

edited

Loading

Uh oh!

Uh oh!

MadLittleMods commented Sep 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

MadLittleMods commented Sep 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Checklist

Uh oh!

Uh oh!

reivilibre Sep 2, 2022

Choose a reason for hiding this comment

Uh oh!

MadLittleMods Sep 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

reivilibre Sep 2, 2022

Choose a reason for hiding this comment

Uh oh!

MadLittleMods Sep 2, 2022

Choose a reason for hiding this comment

Uh oh!

richvdh Sep 6, 2022

Choose a reason for hiding this comment

Uh oh!

MadLittleMods Sep 6, 2022

Choose a reason for hiding this comment

Uh oh!

richvdh Sep 14, 2022

Choose a reason for hiding this comment

Uh oh!

MadLittleMods Sep 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

richvdh Sep 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MadLittleMods commented Sep 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MadLittleMods commented Sep 1, 2022 •

edited

Loading

MadLittleMods Sep 2, 2022 •

edited

Loading

MadLittleMods Sep 14, 2022 •

edited

Loading

richvdh Sep 18, 2022 •

edited

Loading