Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Faster remote room joins: unblock tasks waiting for full room state when the un-partial-stating of that room is received over the replication stream. [rei:frrj/streams/unpsr] #14474

Merged
reivilibre merged 4 commits into from
Dec 6, 2022
+77 −0
Merged

Faster remote room joins: unblock tasks waiting for full room state when the un-partial-stating of that room is received over the replication stream. [rei:frrj/streams/unpsr] #14474

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f715b5a
Wake up blocking rooms
reivilibre Nov 17, 2022
b5910e6
Newsfile
reivilibre Nov 17, 2022
43f713d
Add a test for testing that unblocking await_full_state on rooms work…
reivilibre Nov 17, 2022
2e3c08f
Update tests/replication/tcp/streams/test_partial_state.py
reivilibre Nov 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Wake up blocking rooms
  • Loading branch information
@reivilibre
reivilibre committed Dec 5, 2022
commit f715b5a64d6c7d41a926af2d9a3602276b41a81b
11 changes: 11 additions & 0 deletions synapse/replication/tcp/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,14 @@
TagAccountDataStream,
ToDeviceStream,
TypingStream,
UnPartialStatedRoomStream,
)
from synapse.replication.tcp.streams.events import (
EventsStream,
EventsStreamEventRow,
EventsStreamRow,
)
from synapse.replication.tcp.streams.partial_state import UnPartialStatedRoomStreamRow
from synapse.types import PersistedEventPosition, ReadReceipt, StreamKeyType, UserID
from synapse.util.async_helpers import Linearizer, timeout_deferred
from synapse.util.metrics import Measure
Expand Down Expand Up @@ -117,6 +119,7 @@ def __init__(self, hs: "HomeServer"):
self._streams = hs.get_replication_streams()
self._instance_name = hs.get_instance_name()
self._typing_handler = hs.get_typing_handler()
self._state_storage_controller = hs.get_storage_controllers().state

self._notify_pushers = hs.config.worker.start_pushers
self._pusher_pool = hs.get_pusherpool()
Expand Down Expand Up @@ -236,6 +239,14 @@ async def on_rdata(
self.notifier.notify_user_joined_room(
row.data.event_id, row.data.room_id
)
elif stream_name == UnPartialStatedRoomStream.NAME:
for row in rows:
assert isinstance(row, UnPartialStatedRoomStreamRow)

# Wake up any tasks waiting for the room to be un-partial-stated.
self._state_storage_controller.notify_room_un_partial_stated(
row.room_id
)

await self._presence_handler.process_replication_rows(
stream_name, instance_name, token, rows
Expand Down