Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Fixes #12482 : Remove undocumented device from /pushrules#14679

Closed
JeyRathnam wants to merge 0 commit intomatrix-org:developfrom
JeyRathnam:develop
Closed

Fixes #12482 : Remove undocumented device from /pushrules#14679
JeyRathnam wants to merge 0 commit intomatrix-org:developfrom
JeyRathnam:develop

Conversation

@JeyRathnam
Copy link
Contributor

@JeyRathnam JeyRathnam commented Dec 15, 2022

Signed-off-by: Jeyachandran.rathnam jeyrathnam@proton.me

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

@JeyRathnam JeyRathnam requested a review from a team as a code owner December 15, 2022 01:27
@DMRobertson
Copy link
Contributor

FYI if you write Fixes #12482 in the PR description then Github will automatically mark this PR as closing that issue.

Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I want to double-check no-one is relying on this before we merge.

See #12482 (comment)

@DMRobertson DMRobertson added this to the Revisit: Next Month milestone Dec 15, 2022
@JeyRathnam JeyRathnam changed the title Fix #12482 : Remove undocumented device from /pushrules Fixes #12482 : Remove undocumented device from /pushrules Dec 15, 2022
@JeyRathnam JeyRathnam closed this Dec 16, 2022
@JeyRathnam
Copy link
Contributor Author

@DMRobertson I am not sure why this issue closed, I dont remember closing it.

@clokep
Copy link
Member

clokep commented Dec 22, 2022

@JeyRathnam You should be able to reopen (and maybe merge in develop)!

@clokep
Copy link
Member

clokep commented Dec 23, 2022

Replaced by #14727.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants