This repository was archived by the owner on Apr 26, 2024. It is now read-only.
N + 2: Add not null constraint to column full_user_id of tables profiles and user_filters#15537
Merged
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the next step in #15396. This PR adds a not null constraint to the
full_user_idcolumns of tablesprofilesanduser_filters, and kicks off a background job to migrate entries in the localpart only columns to thefull_user_idcolumns (while transforming them to full user ids in the process).I did test both background jobs manually to verify that they work, but the test wasn't something I could add to the test suite as it involved commenting out the not null constraint to initially populate the localpart only columns.
Part of #15396