This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Ignore encryption_enabled_by_default_for_room_type for notices room#16677
Merged
erikjohnston merged 1 commit intomatrix-org:developfrom Nov 28, 2023
MatMaul:server-notice-disable-encryption
Merged
Ignore encryption_enabled_by_default_for_room_type for notices room#16677erikjohnston merged 1 commit intomatrix-org:developfrom MatMaul:server-notice-disable-encryption
encryption_enabled_by_default_for_room_type for notices room#16677erikjohnston merged 1 commit intomatrix-org:developfrom
MatMaul:server-notice-disable-encryption
Conversation
MatMaul
changed the title
encryption_enabled_by_default_for_room_type for notices room
Contributor
Author
|
Sorry for the force push, this got fully rewrote following wrong assumptions. |
erikjohnston
approved these changes
Nov 28, 2023
Member
erikjohnston
left a comment
erikjohnston
left a comment
There was a problem hiding this comment.
This makes sense given that users aren't allowed to send messages into the server notices room
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the created rooms are encrypted, but the sent notices there are unencrypted which is rather ugly.My assumptions were wrong so this PR got fully rewrote.
It now bypasses
encryption_enabled_by_default_for_room_typesetting when creating server notices room, since the notices will be send unencrypted anyway.Signed-off-by: Mathieu Velten matmaul@gmail.com
Pull Request Checklist
(run the linters)