This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Ignore <noscript> tags when generating URL preview descriptions#2576
Merged
ara4n merged 1 commit intoNov 7, 2017
Conversation
Member
|
Can one of the admins verify this patch? |
2 similar comments
Member
|
Can one of the admins verify this patch? |
Member
|
Can one of the admins verify this patch? |
Member
|
@matrixbot ok to test |
Member
|
@ara4n happy with this? |
Member
|
ecstatically - thanks @maximevaillancourt; sorry it took us a while to review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to do with this PR?
Exclude content in
<noscript>tags from appearing in URL preview descriptions when there is noog:descriptionmeta tag on the page behind said URL.Why are you going with this approach?
Most websites use
<noscript>tags to display a message along the lines of "JavaScript is required to view this page. Please enable JavaScript and try again.". Since such a tag is usually the first child of the<body>element, Synapse picks up these words to approximate the page preview description. By excluding<noscript>tags, Synapse is more likely to end up using words that are actually relevant to the page content.