This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Use SimpleResolverComplexifier in tests#4497
Merged
Merged
Conversation
two reasons for this. One, it saves a bunch of boilerplate. Two, it squashes unicode to IDNA-in-a-`str` (even on python 3) in a way that it turns out we rely on to give consistent behaviour between python 2 and 3.
Codecov Report
@@ Coverage Diff @@
## develop #4497 +/- ##
===========================================
+ Coverage 74.73% 74.73% +<.01%
===========================================
Files 336 336
Lines 34148 34148
Branches 5553 5553
===========================================
+ Hits 25520 25522 +2
+ Misses 7049 7048 -1
+ Partials 1579 1578 -1 |
hawkowl
approved these changes
Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
two reasons for this. One, it saves a bunch of boilerplate. Two, it squashes
unicode to IDNA-in-a-
str(even on python 3) in a way that it turns out werely on to give consistent behaviour between python 2 and 3.