Use v1 and v3 endpoints for /thirdparty tests#1310
Conversation
v1 and v3 endpoints for /thridparty testsv1 and v3 endpoints for /thirdparty tests
thirdparty application service requests
matrix-org/synapse#11158
squahtx
left a comment
There was a problem hiding this comment.
LGTM, but the synapse tests are failing.
Is this blocked on matrix-org/synapse#11158?
|
Yep, this is blocked by that issue. |
|
I made some more changes, I think pairing this with matrix-org/synapse#15317 will fix the tests. I also pushed this as a separate branch: https://github.com/matrix-org/sytest/pull/new/clokep/appservice-urls so that the synapse PR picks up these changes via branch matching. |
|
See https://github.com/matrix-org/sytest/actions/runs/4545210009 run against the matching branch. |
This branch (and the Synapse PR) are all green for Synapse. The PR is all green for Dendrite. I think this is likely OK to merge? Note that I just dropped the legacy paths altogether. I think this is OK since they were from before I'm going to put this back into the review queue for a double check on my logic. |
Updates the endpoints used when testing
/thirdparty