Remove json field names

[iomodo]

Summary

This PR will remove json field names in autolink struct.

Ticket Link

Fixes #115

[codecov-commenter]

Codecov Report

Merging #120 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   48.09%   48.09%           
=======================================
  Files           6        6           
  Lines         576      576           
=======================================
  Hits          277      277           
  Misses        282      282           
  Partials       17       17           

Impacted Files	Coverage Δ
server/autolink/autolink.go	51.06% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc1c8da...4880ffa. Read the comment docs.

[hanzei]

One suggestion, but otherwise LGTM

[hanzei]

0/5 maybe keep the json tags to ensure they stay the same in the future

[levb]

Oops cc @crspeller Thanks for fixing!

[DHaussermann]

@iomodo I seem to be getting results that are quite different from the expected 1.1.1 behavior oulined here #115 (comment)

I have deployed the code change from this PR and my config looks like this (note the chevrons <> get changed when saved into the config.)

                "links": [
                    {
                        "DisableNonWordPrefix": true,
                        "DisableNonWordSuffix": false,
                        "Disabled": false,
                        "Name": "link1",
                        "Pattern": "(?P\u003cmmprefix\u003e^|\\\\s|(?:^| )\\\\()(?P\u003curl\u003ehttps://test\\\\.service/(?P\u003cn\u003eTEST\\\\d{7}))",
                        "Scope": null,
                        "Template": "${mmprefix}[${n}](${url})",
                        "WordMatch": false
                    },
                    {
                        "DisableNonWordPrefix": true,
                        "DisableNonWordSuffix": false,
                        "Disabled": false,
                        "Name": "link2",
                        "Pattern": "(?P\u003cmmprefix\u003e^|\\\\s|(?:^| )\\\\()(?P\u003cn\u003eTEST\\\\d{7})",
                        "Scope": null,
                        "Template": "${mmprefix}[${n}](https://test.service/${n})",
                        "WordMatch": false
                    }
                ],

but I get the output here

It looks like the input does not match the patterns and so auto-link is not doing anything at all. Any thoughts?

[iomodo]

@DHaussermann the problem might be the pattern string, it has too many slashes. Try these:

"Pattern": "(?P\u003cmmprefix\u003e^|\\s|(?:^| )\\()(?P\u003curl\u003ehttps://test\\.service/(?P\u003cn\u003eTEST\\d{7}))",

"Pattern": "(?P\u003cmmprefix\u003e^|\\s|(?:^| )\\()(?P\u003cn\u003eTEST\\d{7})",

[DHaussermann]

Tested and passed

• Tested the input provided in the related issue and I see the desired output
• Tested to ensure enabling word match does not garble results with the sample input as mentioned in the issue
• Added a test for DisableNonWordPrefix to release testing to cover this case
• Regression tested the feature here 8c82b7d that introduced the bug. No issues found with Jira plugin support.
  LGTM!

Thanks @iomodo for the help on this one.