Conversation
hanzei
added
2: Dev Review
levb
approved these changes
Oct 22, 2020
jfrerich
approved these changes
Oct 26, 2020
DHaussermann
approved these changes
Dec 2, 2020
DHaussermann
left a comment
DHaussermann
left a comment
There was a problem hiding this comment.
Tested and passed.
- Tested Fresh install on multiple servers
- When enable radio is True, slash command radio defaults to true as well.
- No issues enabling or disabling
LGTM!
DHaussermann
added
4: Reviews Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Given that in Cloud the slash command are the only way to configure the plugin, we should enabled it by default. The feature has soaked for long enough.
Ticket Link
Fixes #137