-
Notifications
You must be signed in to change notification settings - Fork 170
Render markdown in tooltip with post-utils, instead of ReactMarkdown #327
Copy link
Copy link
Open
Labels
Difficulty/1:EasyEasy ticketEasy ticketGood First IssueSuitable for first-time contributorsSuitable for first-time contributorsHacktoberfestHelp WantedCommunity help wantedCommunity help wantedTech/GoTech/ReactJSType/EnhancementNew feature or improvement of existing featureNew feature or improvement of existing featureUp For GrabsReady for help from the community. Removed when someone volunteersReady for help from the community. Removed when someone volunteers
Metadata
Metadata
Assignees
Labels
Difficulty/1:EasyEasy ticketEasy ticketGood First IssueSuitable for first-time contributorsSuitable for first-time contributorsHacktoberfestHelp WantedCommunity help wantedCommunity help wantedTech/GoTech/ReactJSType/EnhancementNew feature or improvement of existing featureNew feature or improvement of existing featureUp For GrabsReady for help from the community. Removed when someone volunteersReady for help from the community. Removed when someone volunteers
Type
Fields
Give feedbackNo fields configured for issues without a type.
The webapp has a robust markdown system that I think we should utilize instead of using the ReactMarkdown library:
mattermost-plugin-github/webapp/src/components/link_tooltip/link_tooltip.jsx
Lines 118 to 122 in 03935ba
The todo plugin uses the webapp's exposed post-utils to render its markdown. I think it makes sense to do the same here. This would allow for feature-rich things like at-mentions to be rendered as well, assuming the backend does the same sort of translations of GitHub -> Mattermost usernames before the PR description is delivered to the frontend, as it does when it creates posts from a GitHub event.