Expose IANA Time Zone territories to library consumers#64
Expose IANA Time Zone territories to library consumers#64mattjohnsonpint merged 10 commits intomattjohnsonpint:mainfrom
Conversation
Adding editorconfig.
…he mutable dictionary `IanaTimeZoneNamesByTerritory`.
|
@Jehoel - Sorry it's taking me so long to get to reviewing this PR. I definitely appreciate your interest in helping out here! I'm not sure if I fully agree with the form of this API, but I will take a more detailed look and get back to you soon (hopefully!) 😉 With regard to |
|
@mattjohnsonpint Ping? |
|
Reviving this. I brought it up to the current code base and made some more changes. A couple of more things to do to finish before merging. |
|
I reworked the implementation quite a bit, but this gets the same job done you were originally proposing. Thanks again! |
This PR changes the library to expose Territory name information from
TimeZoneConverter.Data.Mapping.csv.gzas a separate dictionary property onTZConvert.I've also added an
.editorconfigfile and unit tests (which pass, though one of the other existing POSIX tests fails, it's not relevant to this PR).I used the existing coding style and conventions (though I did align some statements and add braces to others for the sake of readability). I note that I'm not entirely comfortable with continuing to use mutable collections on
TZConvert. If you're interested I'd love to submit a PR that updates the project to use immutable collections.Update: Removing "001":
I realised that zones were being added for territory "001" - I've updated the PR to exclude those (and added a test to ensure "001" isn't listed). I don't know where "001" comes from - can you explain why it exists and what it means? Thanks!