Pass instructions as system prompt for MLXLanguageModel#48
Conversation
|
Crashing with RESOURCE_TYPE_MEMORY: high watermark memory limit exceeded |
|
@noorbhatia Thanks for your work on this!
Interesting. Was this happening at all without this change? Looking at this MLX issue, it looks like the issue stems from unbounded growth of the KV cache, and can be addressed by either configuring a reasonable limit or resetting after processing the prompt. Aside from that, is there anything more to do with the PR? Or is this ready for review? |
|
Hey @mattt , apologies for the delay. I was able to test it more thoroughly and I think it's ready for review. |
43014bd to
1500acc
Compare
|
Fantastic work, @noorbhatia! I just updated the README to improve instructions for testing MLX. Following those, everything seems to be working as expected. Merging this now. |
Fix #47