Use convertTranscriptToMLXChat in MLXLanguageModel streamResponse#67
Merged
mattt merged 1 commit intomattt:mainfrom Dec 22, 2025
Merged
Use convertTranscriptToMLXChat in MLXLanguageModel streamResponse#67mattt merged 1 commit intomattt:mainfrom
mattt merged 1 commit intomattt:mainfrom
Conversation
Contributor
Author
|
@mattt Can you review this? Current release is breaking due to compiler error in |
Contributor
Author
Contributor
Author
|
Fix #70 |
mattt
approved these changes
Dec 22, 2025
Owner
|
Hi @noorbhatia. I'm sorry for the delay in reviewing this. Thank you for opening this PR. Merging this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update streamResponse to use the same transcript conversion as respond, ensuring streaming responses also have access to full conversation history for multi-turn conversations.
Fixes compiler error from removed
extractInstructionSegmentsandextractPromptSegmentsfunctions