Update CI workflow to build on macOS with all traits enabled#72
Merged
mattt merged 6 commits intomattt:mainfrom Jan 5, 2026
Merged
Update CI workflow to build on macOS with all traits enabled#72mattt merged 6 commits intomattt:mainfrom
mattt merged 6 commits intomattt:mainfrom
Conversation
Owner
|
@XMLHexagram Thank you. This should have been enabled from the start, and would have saved us unnecessary churn and regressions in these latest releases. That was sloppiness on my part stemming from split attention, and a systemic fix is absolutely the right way to go here. |
mattt
reviewed
Jan 5, 2026
mattt
changed the title
Owner
|
OK, good to see that CI is failing in exactly the way we expect to. Let's cherry pick from #71 and try to get everything passing. |
Co-authored-by: XMLHexagram <i@hexagr.am>
Owner
|
@XMLHexagram Thank you again for your help here. I apologize for the frustration I caused by creating these broken releases. I'm hopeful that these checks will help us prevent avoidable mistakes like this in the future. |
This was referenced Jan 5, 2026
Owner
|
I just released 0.5.3 with these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is intended to address the issue caused by the absence of trait enabling in CI builds and tests, which resulted in v0.5.1 and v0.5.2 becoming unusable.