Skip to content

Extends email token documentation in emails.rst#194

Merged
adiati98 merged 24 commits intomautic:5.xfrom
putzwasser:patch-3
Mar 5, 2026
Merged

Extends email token documentation in emails.rst#194
adiati98 merged 24 commits intomautic:5.xfrom
putzwasser:patch-3

Conversation

@putzwasser
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @putzwasser, quite a few changes here - I'm not sure why the linter isn't picking them up and I'm having some problems with my localhost but hopefully the feedback is sufficient!

Comment thread docs/components/emails.rst Outdated
Comment thread docs/components/emails.rst Outdated
Comment thread docs/components/emails.rst Outdated
Comment thread docs/components/emails.rst Outdated
Comment thread docs/components/emails.rst Outdated
Comment thread docs/components/emails.rst Outdated
Comment thread docs/components/emails.rst Outdated
Comment thread docs/components/emails.rst Outdated
Comment thread docs/components/emails.rst Outdated
putzwasser and others added 6 commits June 19, 2024 21:32
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Comment thread docs/components/emails.rst Outdated
Copy link
Copy Markdown
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @putzwasser sorry it's taken us so long to get this over the line.

Do you think we can get the headings fixed in this file? I also fixed a camel case heading as well. Happy to make the commits myself if you haven't got the time to fix it.

Comment thread docs/components/emails.rst Outdated
Comment thread docs/components/emails.rst Outdated
Comment thread docs/components/emails.rst Outdated
Comment thread docs/components/emails.rst Outdated
Comment thread docs/components/emails.rst Outdated
Comment thread docs/components/emails.rst Outdated
@adiati98 adiati98 requested a review from a team as a code owner January 9, 2026 19:35
@adiati98 adiati98 requested review from adiati98 and favour-chibueze and removed request for a team January 9, 2026 19:35
Comment thread docs/components/emails.rst Outdated
Comment thread docs/components/emails.rst Outdated
Comment thread docs/components/emails.rst Outdated
Comment thread docs/components/emails.rst Outdated
@adiati98 adiati98 requested a review from escopecz March 4, 2026 15:03
@adiati98
Copy link
Copy Markdown
Contributor

adiati98 commented Mar 4, 2026

@escopecz if the content is already updated here, I'll remove the note admonition regarding updating docs. Just let me know. Thanks!

escopecz
escopecz previously approved these changes Mar 4, 2026
Copy link
Copy Markdown
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good 👍

* fix capitalization and minor wording adjustment
Comment thread docs/plugin_extensions/emails.rst
adiati98
adiati98 previously approved these changes Mar 5, 2026
Comment thread docs/plugin_extensions/emails.rst Outdated
Comment thread docs/plugin_extensions/emails.rst Outdated
Copy link
Copy Markdown
Contributor

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @putzwasser and @escopecz! 🚀

@adiati98 adiati98 dismissed RCheesley’s stale review March 5, 2026 10:35

All suggestions have been addressed.

@adiati98 adiati98 merged commit d445026 into mautic:5.x Mar 5, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from 🔎 In review to 🥳 Done in Mautic's No/Low/Code Tasks Mar 5, 2026
@adiati98
Copy link
Copy Markdown
Contributor

@RCheesley can you please add @putzwasser to docs at all-contributors? TIA! ✨

@RCheesley
Copy link
Copy Markdown
Member

@all-contributors please add @putzwasser for docs

@allcontributors
Copy link
Copy Markdown
Contributor

@RCheesley

I've put up a pull request to add @putzwasser! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🥳 Done

Development

Successfully merging this pull request may close these issues.

4 participants