This repository was archived by the owner on Aug 10, 2022. It is now read-only.
Add support for custom fields#14
Open
oliverGrist wants to merge 2 commits into
Open
Conversation
brandonduff
reviewed
Sep 21, 2018
brandonduff
left a comment
There was a problem hiding this comment.
This looks good to me. I think adding create, update, and delete makes sense if you'd like to do it.
Someone who is more familiar with this library should probably take a look as well.
| return $this->deleteModel('Expense', $workspaceId, $expenseId); | ||
| } | ||
|
|
||
| // Field Sets |
There was a problem hiding this comment.
We probably don't need these comments. The function names seem to tell the story nicely enough.
Author
|
Awesome, will drop the comments and add the other functions. Thanks.
…Sent from my iPhone
On 21 Sep 2018, at 18:48, Brandon Duff ***@***.***> wrote:
@brandonduff commented on this pull request.
This looks good to me. I think adding create, update, and delete makes sense if you'd like to do it.
Someone who is more familiar with this library should probably take a look as well.
In lib/mavenlink_api.php:
> @@ -222,6 +222,34 @@ function deleteWorkspaceExpense($workspaceId, $expenseId)
{
return $this->deleteModel('Expense', $workspaceId, $expenseId);
}
+
+ // Field Sets
We probably don't need these comments. The function names seem to tell the story nicely enough.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the getters for
Custom Fields,Custom Field SetsandCustom Field Valuesas per the details here: http://developer.mavenlink.com/beta/#tag/Custom-Field-Sets%2Fpaths%2F~1custom_field_sets%2FgetIf this is valid I would be happy to add the create, update and delete functions for these as well.