Skip to content
This repository was archived by the owner on Aug 10, 2022. It is now read-only.

Add support for custom fields#14

Open
oliverGrist wants to merge 2 commits into
mavenlink:masterfrom
oliverGrist:master
Open

Add support for custom fields#14
oliverGrist wants to merge 2 commits into
mavenlink:masterfrom
oliverGrist:master

Conversation

@oliverGrist

@oliverGrist oliverGrist commented Sep 17, 2018

Copy link
Copy Markdown

Add the getters for Custom Fields, Custom Field Sets and Custom Field Values as per the details here: http://developer.mavenlink.com/beta/#tag/Custom-Field-Sets%2Fpaths%2F~1custom_field_sets%2Fget

If this is valid I would be happy to add the create, update and delete functions for these as well.

@brandonduff brandonduff left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I think adding create, update, and delete makes sense if you'd like to do it.

Someone who is more familiar with this library should probably take a look as well.

Comment thread lib/mavenlink_api.php
return $this->deleteModel('Expense', $workspaceId, $expenseId);
}

// Field Sets

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't need these comments. The function names seem to tell the story nicely enough.

@oliverGrist

oliverGrist commented Sep 21, 2018 via email

Copy link
Copy Markdown
Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants