Fix #62: Allow unbounded yaw in player_set_orientation#64
Open
muggymugmug wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #62
Removed the unnecessary modulo by 360 in the player_set_orientation function
In Minecraft, besides the f3 menu, almost everything in the game stores the yaw value as unbounded/unwrapped. So values like 1000° are valid, because they preserve full rotation history.
This fix importantly makes minescript able to achieve natural movement similar to a normal vanilla client.
It also allows for the arm snapping issue to stop (view video attached to understand)
VIDEOS:
Before my fix: here or https://github.com/user-attachments/assets/eca4b0a1-6898-43e0-a77e-30cac27ee2c9
After my fix: here or https://github.com/user-attachments/assets/c3660e7a-deb0-4f43-bf23-29fa1397c945