Mono bent complex string parsing#2395
Conversation
…als repetitions of it
…eing done, instead of the original draft
|
Don’t do that. ;-) Make a dedicated mcstas-dev conda env and make it routine to simply roll a new McStas for all the testing. Use the in-repo dev tools. :-) |
|
I suppose you are right, and that is the proper way to do it. I will do it in the future, but currently I am in a bit of a phase where I am not quite comfortable with the whole conda dev and rolling out new McStas' whenever something should be tested 😅 |
|
I think you might be picking up an older/earlier version? I at least get both here: |
|
And the same is the case if you look within the “passed checks”, e.g. mcstas-conda-basictest:
|
|
@Lomholy I think the state of the PR is good. Let me know if anything is still pending or you feel ready for me to push merge. |
|
I was looking at an older version. I don't have anything pending, so you can go ahead and merge. Thank you for the help with this! |






Free-form text area
Please describe what your PR is adding in terms of features or bugfixes:
Monochromator_bent_complex is updated regarding the changes to the parameter "plane_of_reflections". This is reflected in updates to the header as well. Other minor beauty changes are performed in the header, such as a mu being rendered with html char now, and linking to the article on monochromator_bent.
The plane_of_reflection parameter could previously only be a string of planes, delimited by a semicolon between each plane. With this update, the option of having a single plane of reflection for all crystals is added. E.g. a three crystal array could previously only be instantiated with <plane_of_reflection = "Si111;Si111;Si111"> but now it can also be instantiated by <plane_of_reflection = "Si111">.
Development OS / boundary conditions
Please describe what OS you developed and tested your additions on, and if any special dependencies are required:
Developed on MacOS Tahoe 26.3.1, and no special dependencies are required.
PR Checklist for contributing to McStas/McXtrace
For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:
My contribution includes patches to an existing component file
mcdocutility and rendered a reasonable documentation page for the component (please attach as screenshot in comments!)mctestutility to test one or more instruments making use of the component (please attachmcviewtestreport as screenshot in comments)mccode-clangformattool to apply the standard McCode component indentation schememcrun --c-lint"linter" and followed advice to remove most / all warnings that are raisedMy contribution includes patches to an existing instrument file
mcdocutility and rendered a reasonable documentation page for the instrument (please attach as screenshot in comments!)mctestutility to test the instrument (please attachmcviewtestreport as screenshot in comments)mcrun --c-lint"linter" and followed advice to remove most / all warnings that are raised