Skip to content

refactor: renaming for clarity and consistency#15

Merged
mccutchen merged 1 commit intomainfrom
renaming
Dec 31, 2024
Merged

refactor: renaming for clarity and consistency#15
mccutchen merged 1 commit intomainfrom
renaming

Conversation

@mccutchen
Copy link
Owner

The renames:

websocket.Conn    -> websocket.Websocket
websocket.NewConn -> websocket.New
Read              -> ReadMessage
Write             -> WriteMessage

    websocket.Conn    -> websocket.Websocket
    websocket.NewConn -> websocket.New
    Read              -> ReadMessage
    Write             -> WriteMessage
@mccutchen mccutchen enabled auto-merge (squash) December 31, 2024 04:48
@mccutchen mccutchen merged commit 05edf5a into main Dec 31, 2024
5 checks passed
@mccutchen mccutchen deleted the renaming branch December 31, 2024 04:49
@codecov
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 72.46377% with 19 lines in your changes missing coverage. Please review.

Project coverage is 79.57%. Comparing base (45fe11b) to head (bf9e2bf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
websocket.go 66.66% 9 Missing and 9 partials ⚠️
hooks.go 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #15   +/-   ##
=======================================
  Coverage   79.57%   79.57%           
=======================================
  Files           2        3    +1     
  Lines         421      421           
=======================================
  Hits          335      335           
  Misses         62       62           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant