Skip to content

fix: truncate large frames/messages in test hooks#16

Merged
mccutchen merged 1 commit intomainfrom
hookfix
Dec 31, 2024
Merged

fix: truncate large frames/messages in test hooks#16
mccutchen merged 1 commit intomainfrom
hookfix

Conversation

@mccutchen
Copy link
Owner

It appears that the test hooks used when running the autobahn test suite can contribute to excessive latency when logging the 8 to 16mb frame and message payloads in some of the extreme test cases. For now, let's truncate payloads over an arbitrary length.

@mccutchen mccutchen enabled auto-merge (squash) December 31, 2024 21:01
@mccutchen mccutchen merged commit 38abab2 into main Dec 31, 2024
5 checks passed
@mccutchen mccutchen deleted the hookfix branch December 31, 2024 21:02
@codecov
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.39%. Comparing base (05edf5a) to head (77cbfc6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
proto.go 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   79.57%   79.39%   -0.19%     
==========================================
  Files           3        3              
  Lines         421      427       +6     
==========================================
+ Hits          335      339       +4     
- Misses         62       64       +2     
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant