Skip to content

refactor: unify WriteFrame/WriteFrameMasked#37

Merged
mccutchen merged 3 commits intomainfrom
api-refactor
Feb 2, 2025
Merged

refactor: unify WriteFrame/WriteFrameMasked#37
mccutchen merged 3 commits intomainfrom
api-refactor

Conversation

@mccutchen
Copy link
Owner

Also

  • split MarshalFrame out of WriteFrame for easier reuse (especially in tests)
  • rename CloseFrame -> NewCloseFrame for clarity
  • rename public errors and their messages for more consistency

Also
- split MarshalFrame out of WriteFrame for easier reuse, especially
  in tests
- rename CloseFrame -> NewCloseFrame for clarity/consistency
…iplication is probably more obvious to more readers
@github-actions
Copy link

github-actions bot commented Feb 2, 2025

🔥 Run benchmarks comparing 55ce4c0 against main:

gh workflow run bench.yaml -f pr_number=37

Note: this comment will update with each new commit.

@codecov
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.56%. Comparing base (83b1307) to head (55ce4c0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
websocket.go 72.72% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   88.43%   88.56%   +0.12%     
==========================================
  Files           3        3              
  Lines         441      446       +5     
==========================================
+ Hits          390      395       +5     
- Misses         37       38       +1     
+ Partials       14       13       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mccutchen mccutchen merged commit a558272 into main Feb 2, 2025
9 checks passed
@mccutchen mccutchen deleted the api-refactor branch February 2, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant