Conversation
mccutchen
changed the title
|
🔥 Run benchmarks comparing 872ca70 against gh workflow run bench.yaml -f pr_number=38Note: this comment will update with each new commit. |
mccutchen
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 88.56% 92.44% +3.88%
==========================================
Files 3 3
Lines 446 437 -9
==========================================
+ Hits 395 404 +9
+ Misses 38 26 -12
+ Partials 13 7 -6 ☔ View full report in Codecov by Sentry. |
benchstats: a558272...872ca70View full benchmark output on the workflow summary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storing a single byte rather than three boolean values should be more efficient, especially since (for now) we only need to test whether any RSV bit is set, and now that can happen in a single comparison.
Side note: I asked claude.ai whether this was actually more efficient, and it confidently answered incorrectly that the go compiler would optimizes 3 neighboring bools in a struct, before correcting itself and providing a test program when asked for a reference.
🖼️ claud.ai transcript screenshot (because they don't allow sharing transcripts for some reason?)
Too lazy to compare with ChatGPT or DeepSeek or whatever.