Skip to content

chore: consolidate testing for closed tcp connections#48

Merged
mccutchen merged 1 commit intomainfrom
fix-tcp-close-assertions
Feb 22, 2025
Merged

chore: consolidate testing for closed tcp connections#48
mccutchen merged 1 commit intomainfrom
fix-tcp-close-assertions

Conversation

@mccutchen
Copy link
Owner

A small drive-by improvement. Still not 100% sure this is the right way to approach these tests, or if they're even necessary or the right idea. E.g. what about TCP connection reuse (though I'm not sure if that's even allowed)?

@github-actions
Copy link

🔥 Run benchmarks comparing e422a04 against main:

gh workflow run bench.yaml -f pr_number=48

Note: this comment will update with each new commit.

@codecov
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.37%. Comparing base (aa7a462) to head (e422a04).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files           2        2           
  Lines         459      459           
=======================================
  Hits          424      424           
  Misses         28       28           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mccutchen mccutchen merged commit ae22b5d into main Feb 22, 2025
11 checks passed
@mccutchen mccutchen deleted the fix-tcp-close-assertions branch February 22, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant