refactor: use net.Conn directly instead of io.ReadWriteCloser#66
Merged
refactor: use net.Conn directly instead of io.ReadWriteCloser#66
net.Conn directly instead of io.ReadWriteCloser#66Conversation
Using the latter was unnecessary abstraction that led to unnecessary complexity in library and test code.
|
🔥 Run benchmarks comparing 1b907da against gh workflow run bench.yaml -f pr_number=66Note: this comment will update with each new commit. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
==========================================
- Coverage 96.68% 96.66% -0.02%
==========================================
Files 2 2
Lines 573 570 -3
==========================================
- Hits 554 551 -3
Misses 14 14
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latter was unnecessary abstraction that led to unnecessary complexity in library and test code.