refactor: {Read,Write}Message return errors without closing connection#68
Merged
refactor: {Read,Write}Message return errors without closing connection#68
{Read,Write}Message return errors without closing connection#68Conversation
|
🔥 Run benchmarks comparing c135432 against gh workflow run bench.yaml -f pr_number=68Note: this comment will update with each new commit. |
ReadMessage and WriteMessage return errors without closing connection{Read,Write}Message return errors without closing connection
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 96.99% 98.11% +1.12%
==========================================
Files 2 2
Lines 432 425 -7
==========================================
- Hits 419 417 -2
+ Misses 7 4 -3
+ Partials 6 4 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea here is:
Serve()method for a high-level API that will automatically close the connection when errors are encounteredReadMessage()/WriteMessage()/CloseWithStatus()methods to have more control over connection lifecycle, including the decision about when a read or write error should close the connectionI think this improves the API by making it more explicit, and also simplifies some tests.