Fix: Updates compiler api#1
Open
smilebot wants to merge 1 commit into
Open
Conversation
mcjfunk
approved these changes
Jan 4, 2021
Owner
mcjfunk
left a comment
mcjfunk
left a comment
There was a problem hiding this comment.
This looks good. Did the API change with webpack 5 or was it earlier but deprecated? Just wondering what versions of webpack are supported here. If only webpack 5, please add a note to the README.
BTW, we might want to drop this from the scaffoldings and use one of the other solutions that are popular.
Author
|
Hey Jeff, it was deprecated at an earlier version, I'm trying to track down when. Ex: this post from 2018 . This was breaking when we were trying to upgrade to webpack 5 from 4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compiler.plugin api has been deprecated. This change updates the code to use the newer hooks api