Skip to content

ci(pr-check): expand path filters across pr-check workflows - #44657

Merged
caugner merged 4 commits into
mainfrom
align-pr-check-path-filters
Jul 17, 2026
Merged

ci(pr-check): expand path filters across pr-check workflows#44657
caugner merged 4 commits into
mainfrom
align-pr-check-path-filters

Conversation

@caugner

@caugner caugner commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Description

Expand and normalize the paths: triggers across the pr-check_* workflows:

  • Trigger each workflow when its own workflow file changes.
  • Add .nvmrc where missing (cSpell lists, URL issues).
  • Add relevant dependency files (package.json/package-lock.json for JavaScript and YAML lint; scripts/sort_and_unique_file_lines.js for cSpell lists).
  • Add root-level globs (*.js, *.mjs, *.json, *.jsonc) alongside the existing **/* patterns.

Motivation

Ensure the relevant checks run when a change affects their behavior — whether through the workflow definition itself, the Node version, project dependencies, or files at the repository root.

Additional details

Related issues and pull requests

Normalize the `paths:` triggers so each workflow also runs when its
own file, `.nvmrc`, and relevant dependency files change, and add
root-level globs (`*.js`, `*.mjs`, `*.json`, `*.jsonc`) alongside the
existing `**/*` patterns.
@github-actions github-actions Bot added system [PR only] Infrastructure and configuration for the project size/s [PR only] 6-50 LoC changed labels Jul 7, 2026
@caugner
caugner marked this pull request as ready for review July 7, 2026 14:56
@caugner
caugner requested a review from a team as a code owner July 7, 2026 14:56
@caugner
caugner requested review from LeoMcA and removed request for a team July 7, 2026 14:56

@LeoMcA LeoMcA left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, a couple of comments:

Comment thread .github/workflows/pr-check_yml.yml
Comment thread .github/workflows/pr-check_url-issues.yml
@caugner
caugner merged commit dffeed2 into main Jul 17, 2026
21 checks passed
@caugner
caugner deleted the align-pr-check-path-filters branch July 17, 2026 13:31
estelle pushed a commit to estelle/content that referenced this pull request Jul 28, 2026
* ci(pr-check): expand path filters across pr-check workflows

Normalize the `paths:` triggers so each workflow also runs when its
own file, `.nvmrc`, and relevant dependency files change, and add
root-level globs (`*.js`, `*.mjs`, `*.json`, `*.jsonc`) alongside the
existing `**/*` patterns.

* style(prettier): format scripts

* ci(pr-check_yml): run when root YAML files change

* ci(pr-check_url-issues): add additional paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s [PR only] 6-50 LoC changed system [PR only] Infrastructure and configuration for the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants